From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: after_disk_prepare: Add new hook point ......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/71641/2//COMMIT_MSG Commit Message:
Line 26: } Line 27: Line 28: The VM uuid is available via the vmId environment variable. Line 29: Line 30: The hook is supported only when preparing images before starting a vm.
What are the semantics of hotplug a local disk? Are we creating the disk in
no removal on unplug, no auto-removal at all.
I don't see a need to differentiate between cold plugging and hot plugging. But I can relate to your statement about the hook. Line 31: Other flows preparing drives are not supported. Line 32: Line 33: Change-Id: Ib150682c4afd7f387eabf6873b10eb5eaa858417
vdsm-patches@lists.fedorahosted.org