Change in vdsm[master]: Fix ballooning rules for computing the minimum available memory

[Martin Sivak]

Martin Sivák has uploaded a new change for review.

Change subject: Fix ballooning rules for computing the minimum available memory
......................................................................

Fix ballooning rules for computing the minimum available memory

Change-Id: Ie416db6580462bbd16e80bea0a4e339656eccb0f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025845
Signed-off-by: Martin Sivak 
---
M vdsm/mom.d/02-balloon.policy
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/20849/1

diff --git a/vdsm/mom.d/02-balloon.policy b/vdsm/mom.d/02-balloon.policy
index cc328aa..26c30e2 100644
--- a/vdsm/mom.d/02-balloon.policy
+++ b/vdsm/mom.d/02-balloon.policy
@@ -46,7 +46,7 @@
     # Given current conditions, determine the ideal guest memory size
     (defvar guest_used_mem (- (guest.StatAvg "balloon_cur")
                               (guest.StatAvg "mem_unused")))
-    (defvar balloon_min (min guest.balloon_min (+ guest_used_mem
+    (defvar balloon_min (max guest.balloon_min (+ guest_used_mem
                            (* guest_free_percent guest.balloon_cur))))
     # But do not change it too fast
     (defvar balloon_size (* guest.balloon_cur
@@ -79,7 +79,7 @@
         # Minimally, increase so the guest has its desired free memory
         (defvar guest_used_mem (- (guest.StatAvg "balloon_cur")
                                   (guest.StatAvg "mem_unused")))
-        (defvar balloon_min (min guest.balloon_min (+ guest_used_mem
+        (defvar balloon_min (max guest.balloon_min (+ guest_used_mem
                                (* guest_free_percent guest.balloon_cur))))
         # Otherwise, increase according to the max balloon change
         (defvar balloon_size (* guest.balloon_cur

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fix ballooning rules for computing the minimum available memory
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4406/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5210/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5286/ : SUCCESS

Doron Fediuck has posted comments on this change.

Change subject: Fix ballooning rules for computing the minimum available memory
......................................................................

Patch Set 1: Code-Review+1

[Martin Sivak]

Martin Sivák has posted comments on this change.

Change subject: Fix ballooning rules for computing the minimum available memory
......................................................................

Patch Set 1: Verified+1

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Fix ballooning rules for computing the minimum available memory
......................................................................

Fix ballooning rules for computing the minimum available memory

Change-Id: Ie416db6580462bbd16e80bea0a4e339656eccb0f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025845
Signed-off-by: Martin Sivak 
Reviewed-on: http://gerrit.ovirt.org/20849
Reviewed-by: Doron Fediuck 
Reviewed-by: Dan Kenigsberg 
---
M vdsm/mom.d/02-balloon.policy
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Martin Sivák: Verified
  Doron Fediuck: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Fix ballooning rules for computing the minimum available memory
......................................................................

Patch Set 1: Code-Review+2

Escalating Doron.