Change in vdsm[master]: virt: periodic: HostMonitor: set not-discardable

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has posted comments on this change.

Change subject: virt: periodic: HostMonitor: set not-discardable
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/74492/2/lib/vdsm/virt/periodic.py
File lib/vdsm/virt/periodic.py:

Line 109:             config.getint('vars',
'host_sample_stats_interval'),
Line 110:             scheduler,
Line 111:             timeout=None,
Line 112:             exclusive=True,
Line 113:             discard=False),
I think that we should not whine every timeout (15 seconds), but only after an hour or so
of constant discarding
Line 114: 
Line 115:         Operation(
Line 116:             containersconnection.monitor,
Line 117:             config.getint('vars', 'vm_sample_interval'),


-- 
To view, visit https://gerrit.ovirt.org/74492
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9d6923ad397c85909067747f0d7dd2a94dce8a1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes