Change in vdsm[master]: oop: remove unused properties

Yeela Kaplan has uploaded a new change for review.

Change subject: oop: remove unused properties
......................................................................

oop: remove unused properties

As part of the plan to move from the use of oop
in vdsm to ioprocess, starting cleaning up.

Change-Id: I35f3fae66a4ec71dea99f22d7e085f811f1e1b55
Signed-off-by: Yeela Kaplan <ykaplan(a)redhat.com&gt;
---
M lib/vdsm/config.py.in
M vdsm/storage/outOfProcess.py
2 files changed, 0 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/26174/1

diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index fb597a8..591f268 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -283,11 +283,7 @@
         ('maximum_domains_in_pool', '100',
             'Process pool configuration.'),
 
-        ('process_pool_size', '100', None),
-
         ('process_pool_timeout', '60', None),
-
-        ('process_pool_grace_period', '2', None),
 
         ('process_pool_max_slots_per_domain', '10', None),
 
diff --git a/vdsm/storage/outOfProcess.py b/vdsm/storage/outOfProcess.py
index 65d29e9..6d251ba 100644
--- a/vdsm/storage/outOfProcess.py
+++ b/vdsm/storage/outOfProcess.py
@@ -25,8 +25,6 @@
 
 from remoteFileHandler import RemoteFileHandlerPool
 
-# MAX_HELPERS = config.getint("irs", "process_pool_size")
-# GRACE_PERIOD = config.getint("irs", "process_pool_grace_period")
 DEFAULT_TIMEOUT = config.getint("irs", "process_pool_timeout")
 HELPERS_PER_DOMAIN = config.getint("irs",
"process_pool_max_slots_per_domain")
 


-- 
To view, visit http://gerrit.ovirt.org/26174
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I35f3fae66a4ec71dea99f22d7e085f811f1e1b55
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;

Change in vdsm[master]: oop: remove unused attributes

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: oop: remove unused attributes
......................................................................


oop: remove unused attributes

Change-Id: I35f3fae66a4ec71dea99f22d7e085f811f1e1b55
Signed-off-by: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/26174
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M lib/vdsm/config.py.in
M vdsm/storage/outOfProcess.py
2 files changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Yeela Kaplan: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/26174
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I35f3fae66a4ec71dea99f22d7e085f811f1e1b55
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: oop: remove unused attributes

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: oop: remove unused attributes
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/26174
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35f3fae66a4ec71dea99f22d7e085f811f1e1b55
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: oop: remove unused attributes

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: oop: remove unused attributes
......................................................................


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7869/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7981/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7079/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/26174
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35f3fae66a4ec71dea99f22d7e085f811f1e1b55
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: oop: remove unused properties
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/26174/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-03-27 18:50:23 +0200
Line 6: 
Line 7: oop: remove unused properties
Line 8: 
Line 9: As part of the plan to move from the use of oop
Toni is correct - out of context, this commit message adds more confusion, rather to
alleviate it. The unused configurables (not "properties") should die, and
that's unrelated to future ioprocess plans.
Line 10: in vdsm to ioprocess, starting cleaning up.
Line 11: 
Line 12: Change-Id: I35f3fae66a4ec71dea99f22d7e085f811f1e1b55


-- 
To view, visit http://gerrit.ovirt.org/26174
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35f3fae66a4ec71dea99f22d7e085f811f1e1b55
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Antoni Segura Puimedon has posted comments on this change.

Change subject: oop: remove unused properties
......................................................................


Patch Set 1:

Could you put this patch on a topic branch so that the following patches are tied together
with this one. Maybe the topic branch description could talk about the move from oop to
ioprocess as well.

-- 
To view, visit http://gerrit.ovirt.org/26174
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35f3fae66a4ec71dea99f22d7e085f811f1e1b55
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: oop: remove unused properties
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6890/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7680/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7792/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/26174
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35f3fae66a4ec71dea99f22d7e085f811f1e1b55
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: oop: remove unused attributes

Yeela Kaplan has posted comments on this change.

Change subject: oop: remove unused attributes
......................................................................


Patch Set 2: Verified+1

verified it is unused + pep8 + make

-- 
To view, visit http://gerrit.ovirt.org/26174
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35f3fae66a4ec71dea99f22d7e085f811f1e1b55
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No