Saggi Mizrahi has uploaded a new change for review.
Change subject: [WIP] Add use domain proxies instead of actual domain references ......................................................................
[WIP] Add use domain proxies instead of actual domain references
Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 --- M vdsm/storage/sdc.py 1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/3044/1 -- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add use domain proxies instead of actual domain references ......................................................................
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
Code looks good, but I'm not that familiar with it so I might be missing something.
.................................................... File vdsm/storage/sdc.py Line 41: (due to format conversion for example""" Please close the parenthesis: http://xkcd.com/859/
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add use domain proxies instead of actual domain references ......................................................................
Patch Set 8: I would prefer that you didn't submit this
(1 inline comment)
and Ewoud's docstring comment, too.
.................................................... Commit Message Line 7: Add use domain proxies instead of actual domain references every problem in software engineering can be solved by another level of indirection, that's clear. But what problem is solved now?
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 12: I would prefer that you didn't submit this
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 13: I would prefer that you didn't submit this
(3 inline comments)
Apparently I didn't publish my comments (reviewed this in revision 11). always annoying! Anyway, sorry for the belated review.
.................................................... File vdsm/storage/sdc.py Line 48: return getattr(dom, attrName) this causes a "produce" every time we access any property of the domain, this appears like serious overhead to me.
Line 51: return self._cache._realProduce(self._sdUUID) calling a private method of a different object is not nice.
Line 104: dom = DomainProxy(self, sdUUID) DomainProxy is supposed to get 3 params but you're passing only 2? "def __init__(self, cache, sdUUID):" I'm not sure how this worked for you, what am I missing?
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 13: (1 inline comment)
.................................................... File vdsm/storage/sdc.py Line 104: dom = DomainProxy(self, sdUUID) Note that it's actually equal to:
dom = DomainProxy(cache=self, sdUUID=sdUUID)
The first argument __init__ gets is the created instance.
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 13: (1 inline comment)
.................................................... File vdsm/storage/sdc.py Line 104: dom = DomainProxy(self, sdUUID) True enough, the "(self," syntax threw me off there.
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 13: (2 inline comments)
.................................................... File vdsm/storage/sdc.py Line 41: (due to format conversion for example""" Still would prefer if you closed the parenthesis here.
Line 104: dom = DomainProxy(self, sdUUID) Had to think twice before I could explain it so for readability I'd prefer named parameters here.
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 15: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm/storage/sdc.py Line 48: return getattr(dom, attrName) this still causes a 'produce' every time a property of the domain is accessed ?!?
Line 51: return self._cache._realProduce(self._sdUUID) I still don't like accesses to private methods of other objects.
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 15: (1 inline comment)
.................................................... File vdsm/storage/sdc.py Line 51: return self._cache._realProduce(self._sdUUID) Again, repeating what I said on the previous patchset. Those are "friend" classes. I can make Another private class and then have a public class wrap StorageDomainCache and not expose this method. But I think it's a bit of an over-design. Lets be pragmatic about it.
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 16: I would prefer that you didn't submit this
(1 inline comment)
.................................................... Commit Message Line 12: correctnes errors, espescially on not manager hosts. Having a proxy in which correctness errors do you refer to? do you suggest that we have a case of writer starvation (an old dom instance being re-used, and blocking fresh object from being created)?
We used to have dreams of getting rid of sdc, relying only on lvm cache. And here you add complexity to this module with an effective other level of caching. Is that the best option to solve the correctness errors cited above? let us discuss it deeper.
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 16: (1 inline comment)
.................................................... Commit Message Line 12: correctnes errors, espescially on not manager hosts. Having a proxy in It's the easiest least obtrusive way. You can just remove all the produce calls, remove the pool. Fix the task recovery and cure world hunger.
I just take the practical approach.
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 16: (1 inline comment)
This may be practical, but I need more explanation in order to be comfortable with yet another caching level to be confused about.
.................................................... Commit Message Line 12: correctnes errors, espescially on not manager hosts. Having a proxy in I had several questions above, only one of them was sorta-answered.
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 18: I would prefer that you didn't submit this
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 25: (3 inline comments)
.................................................... File vdsm/storage/sdc.py Line 39: class DomainProxy(object): How about StorageDomainProxy?
Line 51: return self._cache._realProduce(self._sdUUID) I think getRealDomain should be "private" since you already proxy all attributes. Naming it _getRealDomain makes it clear it's not meant to be called unless you know what you're doing.
Line 114: def _realProduce(self, sdUUID): I think Dan mentioned it before, but I agree that mixing these two makes it harder to understand the flow. How about a separate StorageDomainProxyCache which only hold DomainProxies?
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 27: I would prefer that you didn't submit this
I'd like a response to the questions in patch set 25.
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Maor Lipchuk has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 32: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Maor Lipchuk has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 32: No score
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 33: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 33: I would prefer that you didn't submit this
Ayal, Federico,
Is this one so urgent? Cann't we do without it? Does it solve a specific blocking issue?
To me it seems as a solution at the wrong level. The "business logic" should not assume that the disk never changes underneath. Trying to hide the possibility of such changes with notification mechanism is futile.
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 33:
You are right, sadly this isn't the case and you can either hack this in. Or rewrite the entire image handling code.
As the bible says: "Yet he does not leave the guilty unpunished; he punishes the children and their children for the sin of the fathers to the third and fourth generation." ~ Exodus 34:7
We are still paying for sins of version 2 and according to god we have to pay for 4 releases (2.0, 2.2, 3.0, 3.1) Only then redemption shall be upon us.
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 33: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 33: Do not submit
If it is so important, and so urgent, there *must* be a specific bug open on this, and cited by the commit message.
Please do not push before providing a reproducible scenario that is fixed by this patch.
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 35:
If it is so important, and so urgent, there *must* be a specific bug open on this, and cited by the commit message. Please do not push before providing a reproducible scenario that is fixed by this patch.
https://bugzilla.redhat.com/show_bug.cgi?id=842631
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references ......................................................................
Patch Set 35: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: BZ#842631 Use domain proxies instead of actual domain references ......................................................................
Patch Set 36: Verified
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: BZ#842631 Use domain proxies instead of actual domain references ......................................................................
Patch Set 36: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Igor Lvovsky has submitted this change and it was merged.
Change subject: BZ#842631 Use domain proxies instead of actual domain references ......................................................................
BZ#842631 Use domain proxies instead of actual domain references
Because of issues where we had 2 instances of the same domain causing trouble we changed the invalidation scheme to only invalidate when no one is holding a reference to the domain object. This causes a lot of correctnes errors, espescially on not manager hosts. Having a proxy in the middle will allow us to invalidate the domain object and have all reference owners access the correct object.
Signed-off-by: Saggi Mizrahi smizrahi@redhat.com Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 --- M vdsm/storage/sdc.py 1 file changed, 40 insertions(+), 11 deletions(-)
Approvals: Ayal Baron: Looks good to me, approved Federico Simoncelli: Verified Igor Lvovsky:
-- To view, visit http://gerrit.ovirt.org/3044 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838 Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org