Lei Li has uploaded a new change for review.
Change subject: Adjust width for usage_command in vdsm-tool ......................................................................
Adjust width for usage_command in vdsm-tool
The default value of width is 70 characters. It may not be long enough for most of the usage_command comments. So adjust it to add flexibility.
Change-Id: I800384e77452a76f651b73205b3335905274077c Signed-off-by: Lei Li lilei@linux.vnet.ibm.com --- M vdsm-tool/vdsm-tool 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/4648/1 -- To view, visit http://gerrit.ovirt.org/4648 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I800384e77452a76f651b73205b3335905274077c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li lilei@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Adjust width for usage_command in vdsm-tool ......................................................................
Patch Set 2: I would prefer that you didn't submit this
but we *want* textwrap to wrap the text, and not let it flow to its natural length. I do not understand your patch at all.
-- To view, visit http://gerrit.ovirt.org/4648 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I800384e77452a76f651b73205b3335905274077c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li lilei@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com
Itamar Heim has posted comments on this change.
Change subject: Adjust width for usage_command in vdsm-tool ......................................................................
Patch Set 2:
still relevant or should be abandoned?
Yaniv Bronhaim has posted comments on this change.
Change subject: Adjust width for usage_command in vdsm-tool ......................................................................
Patch Set 2:
I didn't even notice this patch. I'll review that asap
Yaniv Bronhaim has posted comments on this change.
Change subject: Adjust width for usage_command in vdsm-tool ......................................................................
Patch Set 2: Code-Review-1
yes. lets leave it with multi-lines for now
Itamar Heim has abandoned this change.
Change subject: Adjust width for usage_command in vdsm-tool ......................................................................
Abandoned
no comment otherwise, abandoning
vdsm-patches@lists.fedorahosted.org