From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: m2c: uses different protocol constant names
......................................................................
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/79664/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 237: ('ssl_excludes', '',
Line 238: 'Comma separated protocol values as defined in '
Line 239: 'https://docs.python.org/2/library/ssl.html. '
Line 240: 'e.g. for ssl OP_NO_TLSv1, OP_NO_TLSv1_1 '
Line 241: ' for m2crypto SSL_OP_NO_TLSv1, SSL_OP_NO_TLSv1_1 '
funny.. just except both and do the conversion yourself based on the implementation you
use. it will make the user's life easier
Line 242: 'By default tlv1, tlsv1.1 and tlsv1.2 are '
Line 243: 'enabled.'),
Line 244:
Line 245: ('connection_stats_timeout', '3600',
https://gerrit.ovirt.org/#/c/79664/2/lib/vdsm/m2cutils.py
File lib/vdsm/m2cutils.py:
Line 336: # not all m2crypto provide this constant
Line 337: excludes |= 268435456
Line 338: else:
Line 339: excludes |= getattr(m2, no_protocol.strip())
Line 340:
you are calling no_protocol.strip() in the condition, so the attr probably exists.. what
constant m2crypto is not provided?
--
To view, visit
https://gerrit.ovirt.org/79664
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c05bddfba94d85e2c48122b6fd56d8f336d01f5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes