Change in vdsm[ovirt-4.1]: vdsm metrics: replace dots with underscore in entity names

[Code Review]

From Yaniv Bronhaim <ybronhei(a)redhat.com&gt;:

Yaniv Bronhaim has uploaded a new change for review.

Change subject: vdsm metrics: replace dots with underscore in entity names
......................................................................

vdsm metrics: replace dots with underscore in entity names

statsd recognize dots as entering to subtree. If a nic name includes
dot in their name we convert it to underscore to avoid
recognize it as sub metric tree in collectd

Change-Id: If097f45d9f9d65bd056371234255e91609656ae5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1433734
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
---
M lib/vdsm/host/api.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/75998/1

diff --git a/lib/vdsm/host/api.py b/lib/vdsm/host/api.py
index d9ee16b..b3f77e9 100644
--- a/lib/vdsm/host/api.py
+++ b/lib/vdsm/host/api.py
@@ -122,7 +122,7 @@
         if 'network' in hoststats:
             for interface in hoststats['network']:
                 if_info = hoststats['network'][interface]
-                net_prefix = prefix + '.nic.' + interface
+                net_prefix = prefix + '.nic.' + interface.replace('.',
'_')
                 data[net_prefix + '.speed'] = if_info['speed']
                 data[net_prefix + '.rx_errors'] = if_info['rxErrors']
                 data[net_prefix + '.tx_errors'] = if_info['txErrors']


-- 
To view, visit https://gerrit.ovirt.org/75998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If097f45d9f9d65bd056371234255e91609656ae5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;

[Code Review]

From Yaniv Bronhaim <ybronhei(a)redhat.com&gt;:

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm metrics: replace dots with underscore in entity names
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/75998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If097f45d9f9d65bd056371234255e91609656ae5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No