Saggi Mizrahi has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement ......................................................................
Patch Set 4:
(1 comment)
Ignore my previous comment, looks good. Minor comments
.................................................... File lib/vdsm/vdscli.py.in Line 50: else: Line 51: result = func(self.transport, *args, **kwargs) Line 52: except ExpatError as e: Line 53: print 'Parsing error thrown during parsing response.\ Line 54: Following arguments were passed:' Please use proper ("line a" "line b") instead of using \ Line 55: for name, value in kwargs.items(): Line 56: print '{0} = {1}'.format(name, value) Line 57: raise e Line 58: return result
vdsm-patches@lists.fedorahosted.org