Change in vdsm[master]: configNetwork: add restoreAtomicNetworkBackup

[Igor Lvovsky]

Igor Lvovsky has uploaded a new change for review.

Change subject: configNetwork: add restoreAtomicNetworkBackup
......................................................................

configNetwork: add restoreAtomicNetworkBackup

Change-Id: I132aa07c6fa2d0bd56ab5a6a79134aed4d0bfb85
Signed-off-by: Igor Lvovsky 
---
M vdsm/clientIF.py
M vdsm/configNetwork.py
2 files changed, 31 insertions(+), 9 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/6915/1
--
To view, visit http://gerrit.ovirt.org/6915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I132aa07c6fa2d0bd56ab5a6a79134aed4d0bfb85
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: configNetwork: add restoreAtomicNetworkBackup
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/configNetwork.py
Line 195:     def removeLibvirtNetwork(self, network, backup=True):
for symmetry, please split to a locate _removeNetwork without backup. this function should ALWAYS back up.

Line 260:         if not self._networksBackups:
this condition is not required

--
To view, visit http://gerrit.ovirt.org/6915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I132aa07c6fa2d0bd56ab5a6a79134aed4d0bfb85
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Livnat Peer

Change in vdsm[master]: BZ#832765 - configNetwork: add restoreAtomicNetworkBackup

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#832765 - configNetwork: add restoreAtomicNetworkBackup
......................................................................

Patch Set 3: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/6915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I132aa07c6fa2d0bd56ab5a6a79134aed4d0bfb85
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer

Change in vdsm[master]: BZ#832765 - configNetwork: add restoreAtomicNetworkBackup

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#832765 - configNetwork: add restoreAtomicNetworkBackup
......................................................................

BZ#832765 - configNetwork: add restoreAtomicNetworkBackup

Change-Id: I132aa07c6fa2d0bd56ab5a6a79134aed4d0bfb85
Signed-off-by: Igor Lvovsky 
---
M vdsm/configNetwork.py
1 file changed, 25 insertions(+), 6 deletions(-)

Approvals:
  oVirt Jenkins CI Server: Verified
  Dan Kenigsberg: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/6915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I132aa07c6fa2d0bd56ab5a6a79134aed4d0bfb85
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: oVirt Jenkins CI Server