Change in vdsm[master]: volume: fix constants in validateCreateVolumeParams

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: volume: fix constants in validateCreateVolumeParams
......................................................................

volume: fix constants in validateCreateVolumeParams

This patch solves a problem related to the use of the volume constants.
The issue, introduced in 9d15a8c, was hid by subsequent patches in the
same series.

Change-Id: I2d809f51f68935e3c1d4670ee1556e262dd1b10f
Signed-off-by: Federico Simoncelli 
---
M vdsm/storage/volume.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/28250/1

diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py
index a1cb54b..d2298f7 100644
--- a/vdsm/storage/volume.py
+++ b/vdsm/storage/volume.py
@@ -368,7 +368,7 @@
             raise se.IncorrectType(type2name(preallocate))

# Volumes with a parent must be cow
-        if srcVolUUID != volume.BLANK_UUID and volFormat != volume.COW_FORMAT:
+        if srcVolUUID != BLANK_UUID and volFormat != COW_FORMAT:
             raise se.IncorrectFormat(srcVolUUID)

@classmethod

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: volume: fix constants in validateCreateVolumeParams
......................................................................

Patch Set 1: Verified+1 Code-Review+2

Verified building. +2 because it fixes a build issue on master.

[Federico Simoncelli]

Federico Simoncelli has submitted this change and it was merged.

Change subject: volume: fix constants in validateCreateVolumeParams
......................................................................

volume: fix constants in validateCreateVolumeParams

This patch solves a problem related to the use of the volume constants.
The issue, introduced in 9d15a8c, was hid by subsequent patches in the
same series.

Change-Id: I2d809f51f68935e3c1d4670ee1556e262dd1b10f
Signed-off-by: Federico Simoncelli 
Reviewed-on: http://gerrit.ovirt.org/28250
---
M vdsm/storage/volume.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Federico Simoncelli: Verified; Looks good to me, approved

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: volume: fix constants in validateCreateVolumeParams
......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1381/ : SUCCESS

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: volume: fix constants in validateCreateVolumeParams
......................................................................

Patch Set 1:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9623/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8691/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9477/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_ge... : FAILURE