3:28 p.m.
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: storage: fix pep issue with image.py
......................................................................
storage: fix pep issue with image.py
This patch fix the if indentation that pep complains.
Introduced by patch 7b4bd1b4.
Change-Id: I82b7e096292799b5c7e7f7f595e094643014ea69
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M vdsm/storage/image.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/27273/1
diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py
index 3d32a22..f50ad29 100644
--- a/vdsm/storage/image.py
+++ b/vdsm/storage/image.py
@@ -359,7 +359,7 @@
# soon filled with the data coming from the copy) and then
# we change its metadata back to the original value.
if (destDom.supportsSparseness or
- volParams['volFormat'] != volume.RAW_FORMAT):
+ volParams['volFormat'] != volume.RAW_FORMAT):
tmpVolPreallocation = volume.SPARSE_VOL
else:
tmpVolPreallocation = volume.PREALLOCATED_VOL
--
To view, visit http://gerrit.ovirt.org/27273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82b7e096292799b5c7e7f7f595e094643014ea69
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
8:31 p.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: storage: fix pep issue with image.py
......................................................................
Patch Set 2:
Hi Tal,
Recommend you to update to this version if you are using EL6.
http://danken.fedorapeople.org/python-pep8-1.4.5-2.el6.noarch.rpm
--
To view, visit http://gerrit.ovirt.org/27273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82b7e096292799b5c7e7f7f595e094643014ea69
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:33 p.m.
Tal Nisan has posted comments on this change.
Change subject: storage: fix pep issue with image.py
......................................................................
Patch Set 2:
I meant *a couple of hours after the merge
--
To view, visit http://gerrit.ovirt.org/27273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82b7e096292799b5c7e7f7f595e094643014ea69
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:12 p.m.
Tal Nisan has posted comments on this change.
Change subject: storage: fix pep issue with image.py
......................................................................
Patch Set 2:
On the contrary, I totally agreed with Douglas, the Jenkins build also failed although it
was a couple of hours merge, the merge, I was just wondering how my pep8 missed it but
upon comparing the version with the one Jenkins uses it appears that it is indeed a
different version
--
To view, visit http://gerrit.ovirt.org/27273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82b7e096292799b5c7e7f7f595e094643014ea69
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:03 p.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: storage: fix pep issue with image.py
......................................................................
storage: fix pep issue with image.py
This patch fix the if indentation that pep complains.
Introduced by patch 7b4bd1b4.
Change-Id: I82b7e096292799b5c7e7f7f595e094643014ea69
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/27273
Reviewed-by: Tal Nisan <tnisan(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/storage/image.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified
Tal Nisan: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82b7e096292799b5c7e7f7f595e094643014ea69
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
4:03 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: storage: fix pep issue with image.py
......................................................................
Patch Set 1: Code-Review+2
There are too manyversions of the pep8 tool.
Trusting Douglas regarding the fix.
--
To view, visit http://gerrit.ovirt.org/27273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82b7e096292799b5c7e7f7f595e094643014ea69
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:03 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: storage: fix pep issue with image.py
......................................................................
Patch Set 1:
There are too manyversions of the pep8 tool.
Trusting Douglas regarding the fix.
--
To view, visit http://gerrit.ovirt.org/27273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82b7e096292799b5c7e7f7f595e094643014ea69
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:33 p.m.
Tal Nisan has posted comments on this change.
Change subject: storage: fix pep issue with image.py
......................................................................
Patch Set 1: Code-Review+1
Fix seems ok but it's strange, I double checked with pep8 on image.py before pushing
the patch, how come it didn't complain, is there something I'm missing?
--
To view, visit http://gerrit.ovirt.org/27273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82b7e096292799b5c7e7f7f595e094643014ea69
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:32 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storage: fix pep issue with image.py
......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8457/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7667/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8578/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/27273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82b7e096292799b5c7e7f7f595e094643014ea69
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:29 p.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: storage: fix pep issue with image.py
......................................................................
Patch Set 1: Verified+1
fix the error during the build:
./vdsm/storage/image.py:362:25: E125 continuation line does not distinguish itself from
next logical line
--
To view, visit http://gerrit.ovirt.org/27273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82b7e096292799b5c7e7f7f595e094643014ea69
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
3659
days inactive
3660
days old
vdsm-patches@lists.fedorahosted.org
9 comments
4 participants
participants (4)
-
Dan Kenigsberg -
Douglas Schilling Landgraf -
Jenkins CI RO -
tnisan＠redhat.com