Change in vdsm[master]: BZ#783150 - change vm channel name suffix to suit upstream

[Haim Ateya]

Haim Ateya has uploaded a new change for review.

Change subject: BZ#783150 - change vm channel name suffix to suit upstream
......................................................................

BZ#783150 - change vm channel name suffix to suit upstream

Change-Id: Ic7cb8590bd8101e9d5be66d81e95de4f63835a57
---
M vdsm/libvirtvm.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/1146/1
--
To view, visit http://gerrit.ovirt.org/1146
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7cb8590bd8101e9d5be66d81e95de4f63835a57
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#783150 - change vm channel name suffix to suit upstream
......................................................................

Patch Set 1: I would prefer that you didn't submit this

This patch cannot go in without a compatible change enters ovirt-guest-agent. I believe the guest would have to search for both names in order to be backward-compatible.

Please update the commit message with a information of the agent change.

--
To view, visit http://gerrit.ovirt.org/1146
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7cb8590bd8101e9d5be66d81e95de4f63835a57
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#783150 - change vm channel name suffix to suit upstream
......................................................................

Patch Set 1:

oh, and there's

com.redhat.spice.0

with the very same trademark problem.

--
To view, visit http://gerrit.ovirt.org/1146
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7cb8590bd8101e9d5be66d81e95de4f63835a57
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#783150 - change vm channel name suffix to suit upstream
......................................................................

Patch Set 2: I would prefer that you didn't submit this

Haim, I think you've missed my point. The commit message should have a link to the guest agent patch (and spice?). The patch(es) should enter into there before the Vdsm patch can be taken in.

--
To view, visit http://gerrit.ovirt.org/1146
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7cb8590bd8101e9d5be66d81e95de4f63835a57
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Haim Ateya