From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: link.bond - handling of arp_ip_target
......................................................................
net: link.bond - handling of arp_ip_target
Reading: To enable an unified handling of all bonding options,
the bond option arp_ip_target is internally converted in the
representation which is accepted by the ifcfg-bond* files.
In details, the bond option arp_ip_target could contain multiple
values, which are separated by space in
/sys/class/net/%s/bonding/arp_ip_target.
Separate this values inside vdsm by comma, to enable an unified
handling for all bonding options.
Setting: Enable the bond option arp_ip_target to be set by
BondSysFS.set_options. Adding and removing values by writing to
/sys/class/net/%s/bonding/arp_ip_target requires a command-like
interface. Extend link.bond to handle this interface.
Add an unit and a functional test for setting and reading
arp_ip_target.
Change-Id: Ia016edcc1d346e8c7654fd65758220db422bbe47
Bug-Url:
https://bugzilla.redhat.com/1412563
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
---
M lib/vdsm/network/link/bond/sysfs_options.py
M tests/network/func_bond_basic_test.py
M tests/network/link_bond_test.py
3 files changed, 121 insertions(+), 7 deletions(-)
Approvals:
Dominik Holler: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/70943
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia016edcc1d346e8c7654fd65758220db422bbe47
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>