8:57 p.m.
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec: load bridge module
......................................................................
vdsm.spec: load bridge module
if bridge module is not loaded
net.bridge.bridge-nf-call-* is ignored by sysctl.
Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/11610/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 7cccfd4..8e385d8 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -502,6 +502,7 @@
fi
# Make the /etc/sysctl.d/vdsm take effect immediately after installation.
+/sbin/modprobe bridge
/sbin/sysctl -q -p /etc/sysctl.d/vdsm
%if 0%{?rhel}
--
To view, visit http://gerrit.ovirt.org/11610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
9 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: load bridge module
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1026/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1061/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/172/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/11610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:57 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: load bridge module
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/172/ (3/3)
--
To view, visit http://gerrit.ovirt.org/11610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:57 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: load bridge module
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1061/ (2/3)
--
To view, visit http://gerrit.ovirt.org/11610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:57 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: load bridge module
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1026/ (1/3)
--
To view, visit http://gerrit.ovirt.org/11610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
1:58 p.m.
New subject: Change in vdsm[master]: load_needed_modules: adding bridge module
Dan Kenigsberg has submitted this change and it was merged.
Change subject: load_needed_modules: adding bridge module
......................................................................
load_needed_modules: adding bridge module
if bridge module is not loaded
net.bridge.bridge-nf-call-* is ignored by sysctl.
Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M vdsm-tool/load_needed_modules.py.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
1:58 p.m.
New subject: Change in vdsm[master]: load_needed_modules: adding bridge module
Dan Kenigsberg has posted comments on this change.
Change subject: load_needed_modules: adding bridge module
......................................................................
Patch Set 3: Looks good to me, approved
jenkins failure is unrelated to this patch.
--
To view, visit http://gerrit.ovirt.org/11610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
8:56 a.m.
New subject: Change in vdsm[master]: load_needed_modules: adding bridge module
oVirt Jenkins CI Server has posted comments on this change.
Change subject: load_needed_modules: adding bridge module
......................................................................
Patch Set 3: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1029/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1064/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/175/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/11610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:54 a.m.
New subject: Change in vdsm[master]: load_needed_modules: adding bridge module
Douglas Schilling Landgraf has posted comments on this change.
Change subject: load_needed_modules: adding bridge module
......................................................................
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/11610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:54 a.m.
New subject: Change in vdsm[master]: load_needed_modules: adding bridge module
oVirt Jenkins CI Server has posted comments on this change.
Change subject: load_needed_modules: adding bridge module
......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1029/ (3/3)
--
To view, visit http://gerrit.ovirt.org/11610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:54 a.m.
New subject: Change in vdsm[master]: load_needed_modules: adding bridge module
oVirt Jenkins CI Server has posted comments on this change.
Change subject: load_needed_modules: adding bridge module
......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/175/ (1/3)
--
To view, visit http://gerrit.ovirt.org/11610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:54 a.m.
New subject: Change in vdsm[master]: load_needed_modules: adding bridge module
oVirt Jenkins CI Server has posted comments on this change.
Change subject: load_needed_modules: adding bridge module
......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1064/ (2/3)
--
To view, visit http://gerrit.ovirt.org/11610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:21 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: load bridge module
......................................................................
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1027/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1062/ : ABORTED
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/173/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/11610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:44 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm.spec: load bridge module
......................................................................
Patch Set 2: I would prefer that you didn't submit this
I think it would fit better into load_needed_modules.py.in
--
To view, visit http://gerrit.ovirt.org/11610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:17 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: load bridge module
......................................................................
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:16 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: load bridge module
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1027/ (3/3)
--
To view, visit http://gerrit.ovirt.org/11610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:16 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: load bridge module
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1062/ (2/3)
--
To view, visit http://gerrit.ovirt.org/11610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:16 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: load bridge module
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/173/ (1/3)
--
To view, visit http://gerrit.ovirt.org/11610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:52 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: load bridge module
......................................................................
Patch Set 1: I would prefer that you didn't submit this
new version..
--
To view, visit http://gerrit.ovirt.org/11610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a6bf5d93060105de9ad1d4d4d89d119913c98c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4126
days inactive
4126
days old
vdsm-patches@lists.fedorahosted.org
18 comments
3 participants
participants (3)
-
Dan Kenigsberg -
Douglas Schilling Landgraf -
Jenkins CI RO