Change in vdsm[master]: testrunner: Add NOSE_COLOR env var

Saggi Mizrahi has uploaded a new change for review.

Change subject: testrunner: Add NOSE_COLOR env var
......................................................................

testrunner: Add NOSE_COLOR env var

Allows forcing output of color to non terminal.

Useful for case where the errors are longer then the scrollback:

NOSE_COLOR=1 ./run_tests_local.sh jsonRpcTests | less -R

Change-Id: I4eb684c73f6254a35707fcd7f3f6b30eaaae9f2f
Signed-off-by: Saggi Mizrahi 
---
M tests/testrunner.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/12302/1

diff --git a/tests/testrunner.py b/tests/testrunner.py
index 2c55a51..1880736 100644
--- a/tests/testrunner.py
+++ b/tests/testrunner.py
@@ -115,7 +115,7 @@

def colorWrite(stream, text, color):
-    if os.isatty(stream.fileno()):
+    if os.isatty(stream.fileno()) or os.environ.get("NOSE_COLOR", False):
         stream.write('\x1b[%s;1m%s\x1b[0m' % (color, text))
     else:
         stream.write(text)

--
To view, visit http://gerrit.ovirt.org/12302
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4eb684c73f6254a35707fcd7f3f6b30eaaae9f2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: testrunner: Add NOSE_COLOR env var
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/482/ (2/3)

--
To view, visit http://gerrit.ovirt.org/12302
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eb684c73f6254a35707fcd7f3f6b30eaaae9f2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: testrunner: Add NOSE_COLOR env var
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1335/ (1/3)

--
To view, visit http://gerrit.ovirt.org/12302
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eb684c73f6254a35707fcd7f3f6b30eaaae9f2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: testrunner: Add NOSE_COLOR env var
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1373/ (3/3)

--
To view, visit http://gerrit.ovirt.org/12302
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eb684c73f6254a35707fcd7f3f6b30eaaae9f2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: testrunner: Add NOSE_COLOR env var
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1335/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1373/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/482/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/12302
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eb684c73f6254a35707fcd7f3f6b30eaaae9f2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: testrunner: Add NOSE_COLOR env var
......................................................................

Patch Set 1: Looks good to me, approved

I'm not sure that "nose" would be happy that we sneak into their NOSE_* namespace, but I do not really mind.

--
To view, visit http://gerrit.ovirt.org/12302
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eb684c73f6254a35707fcd7f3f6b30eaaae9f2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: testrunner: Add NOSE_COLOR env var
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1910/ (1/2)

--
To view, visit http://gerrit.ovirt.org/12302
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eb684c73f6254a35707fcd7f3f6b30eaaae9f2f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: testrunner: Add NOSE_COLOR env var
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1859/ (2/2)

--
To view, visit http://gerrit.ovirt.org/12302
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eb684c73f6254a35707fcd7f3f6b30eaaae9f2f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: testrunner: Add NOSE_COLOR env var
......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1859/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1910/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/12302
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eb684c73f6254a35707fcd7f3f6b30eaaae9f2f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: testrunner: Add NOSE_COLOR env var
......................................................................

testrunner: Add NOSE_COLOR env var

Allows forcing output of color to non terminal.

Useful for case where the errors are longer then the scrollback:

NOSE_COLOR=1 ./run_tests_local.sh jsonRpcTests | less -R

Change-Id: I4eb684c73f6254a35707fcd7f3f6b30eaaae9f2f
Signed-off-by: Saggi Mizrahi 
---
M tests/testrunner.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/12302
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4eb684c73f6254a35707fcd7f3f6b30eaaae9f2f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: testrunner: Add NOSE_COLOR env var
......................................................................

Patch Set 2: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/12302
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eb684c73f6254a35707fcd7f3f6b30eaaae9f2f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: oVirt Jenkins CI Server