Change in vdsm[master]: check-merged: give a significant name to lago_ovirt_http_pid

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has uploaded a new change for review.

Change subject: check-merged: give a significant name to lago_ovirt_http_pid
......................................................................

check-merged: give a significant name to lago_ovirt_http_pid

Change-Id: I2533b1a0580baa516614fd058897489d039ea0ab
Signed-off-by: Dan Kenigsberg 
---
M automation/check-merged.sh
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/71698/1

diff --git a/automation/check-merged.sh b/automation/check-merged.sh
index 32ef4a5..fd2350e 100755
--- a/automation/check-merged.sh
+++ b/automation/check-merged.sh
@@ -95,7 +95,7 @@
     lago ovirt deploy

lago ovirt serve &
-    PID=$!
+    local lago_ovirt_http_pid=$!

fake_ksm_in_vm

@@ -106,7 +106,7 @@
     res="${PIPESTATUS[0]}"
     [ "$res" -ne 0 ] && failed="$res"

-    kill $PID
+    kill "$lago_ovirt_http_pid"

lago copy-from-vm \
     "$VM_NAME" \

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: check-merged: give a significant name to lago_ovirt_http_pid
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/71698/1/automation/check-merged.sh
File automation/check-merged.sh:

Line 105
Line 106
Line 107
Line 108
Line 109
errr I forgot about my https://gerrit.ovirt.org/#/c/70825/8/automation/check-merged.sh

need to update.. and now rebase as well

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: check-merged: give a significant name to lago_ovirt_http_pid
......................................................................

Patch Set 2: Code-Review+2 Verified+1

bash part is fine http://jenkins.ovirt.org/job/vdsm_master_check-merged-el7-x86_64/1212/consol...

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: check-merged: give a significant name to lago_ovirt_http_pid
......................................................................

Patch Set 3: Continuous-Integration+1

bash part is fine; Paramiko kills job.

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged.

Change subject: check-merged: give a significant name to lago_ovirt_http_pid
......................................................................

check-merged: give a significant name to lago_ovirt_http_pid

Change-Id: I2533b1a0580baa516614fd058897489d039ea0ab
Signed-off-by: Dan Kenigsberg 
---
M automation/check-merged.sh
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Irit Goihman: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests