10:33 a.m.
Federico Simoncelli has uploaded a new change for review.
Change subject: Add the live snapshot command to vdsClient
......................................................................
Add the live snapshot command to vdsClient
Add the new vdsClient command to take live snapshots:
vdsClient [-s] <host> snapshot \
<vmId> <vmDisk> <sdUUID> <spUUID> <imgUUID>
<volUUID>
Change-Id: I20a6811ea8c7908969eb69d721b39c479f304d08
---
M vdsm_cli/vdsClient.py
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/515/1
--
To view, visit http://gerrit.ovirt.org/515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I20a6811ea8c7908969eb69d721b39c479f304d08
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
9:34 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add the live snapshot command to vdsClient
......................................................................
Add the live snapshot command to vdsClient
Add the new vdsClient command to take live snapshots:
vdsClient [-s] <host> snapshot <vmId> \
<sdUUID> <spUUID> <imgUUID> <baseVolUUID> <volUUID>
Change-Id: I20a6811ea8c7908969eb69d721b39c479f304d08
---
M vdsm_cli/vdsClient.py
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
Igor Lvovsky: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I20a6811ea8c7908969eb69d721b39c479f304d08
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
9:34 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Add the live snapshot command to vdsClient
......................................................................
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20a6811ea8c7908969eb69d721b39c479f304d08
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
9:32 a.m.
Igor Lvovsky has posted comments on this change.
Change subject: Add the live snapshot command to vdsClient
......................................................................
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20a6811ea8c7908969eb69d721b39c479f304d08
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
7:48 a.m.
Igor Lvovsky has posted comments on this change.
Change subject: Add the live snapshot command to vdsClient
......................................................................
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20a6811ea8c7908969eb69d721b39c479f304d08
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4:49 p.m.
Federico Simoncelli has posted comments on this change.
Change subject: Add the live snapshot command to vdsClient
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm_cli/vdsClient.py
Line 1474: vmDisk: {
The API is capable to take a snapshot of multiple disks at the same time. That is not
implemented in the command line.
--
To view, visit http://gerrit.ovirt.org/515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20a6811ea8c7908969eb69d721b39c479f304d08
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
7:39 a.m.
Igor Lvovsky has posted comments on this change.
Change subject: Add the live snapshot command to vdsClient
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20a6811ea8c7908969eb69d721b39c479f304d08
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
9:06 a.m.
Igor Lvovsky has posted comments on this change.
Change subject: Add the live snapshot command to vdsClient
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File vdsm_cli/vdsClient.py
Line 1951: "Take a live snapshot"
Maybe we need to explain what is baseVolUUID and what is volUUID
--
To view, visit http://gerrit.ovirt.org/515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20a6811ea8c7908969eb69d721b39c479f304d08
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12:03 p.m.
Igor Lvovsky has posted comments on this change.
Change subject: Add the live snapshot command to vdsClient
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
Only minor comment
--
To view, visit http://gerrit.ovirt.org/515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20a6811ea8c7908969eb69d721b39c479f304d08
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
8:21 a.m.
Adam Litke has posted comments on this change.
Change subject: Add the live snapshot command to vdsClient
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20a6811ea8c7908969eb69d721b39c479f304d08
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4:03 p.m.
Adam Litke has posted comments on this change.
Change subject: Add the live snapshot command to vdsClient
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm_cli/vdsClient.py
Line 1474: vmDisk: {
Oops. I think I misread the code. It looks like vmDIsk is a string for the name of the
disk. Got it now (sorry for the noise).
--
To view, visit http://gerrit.ovirt.org/515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20a6811ea8c7908969eb69d721b39c479f304d08
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4 p.m.
Adam Litke has posted comments on this change.
Change subject: Add the live snapshot command to vdsClient
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm_cli/vdsClient.py
Line 1474: vmDisk: {
Why do you pass in a vmDisk parameter when you don't even use it? It looks like you
are passing your own vmDisk that you construct from the sd, sp, img, and vol UUIDs.
--
To view, visit http://gerrit.ovirt.org/515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20a6811ea8c7908969eb69d721b39c479f304d08
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4:21 p.m.
Saggi Mizrahi has posted comments on this change.
Change subject: Add the live snapshot command to vdsClient
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20a6811ea8c7908969eb69d721b39c479f304d08
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4469
days inactive
4524
days old
vdsm-patches@lists.fedorahosted.org
12 comments
5 participants
participants (5)
-
agl＠us.ibm.com -
Dan Kenigsberg -
Federico Simoncelli -
Igor Lvovsky -
smizrahi＠redhat.com