Change in vdsm[master]: [WIP] Remove the shared code from BlockVolume.create

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: [WIP] Remove the shared code from BlockVolume.create
......................................................................

[WIP] Remove the shared code from BlockVolume.create

Signed-off-by: Federico Simoncelli 
Change-Id: I4e6b97c36b17f63773013e7d2eed2a57a600bedb
---
M vdsm/storage/blockVolume.py
1 file changed, 41 insertions(+), 119 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/3628/1
--
To view, visit http://gerrit.ovirt.org/3628
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e6b97c36b17f63773013e7d2eed2a57a600bedb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: [WIP] Remove the shared code from BlockVolume.create
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/blockVolume.py
Line 199:         return mdSlot
I don't like this very much, I'll try to get rid of it (or make a sense out of it).

--
To view, visit http://gerrit.ovirt.org/3628
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e6b97c36b17f63773013e7d2eed2a57a600bedb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: [WIP] Remove the shared code from BlockVolume.create
......................................................................

Patch Set 2: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File vdsm/storage/blockVolume.py
Line 162:             os.unlink(volPath)
Don't we have a safe unlink method in fileutils? If we don't this could be a really good implementation for one

Line 169:         cls.log.info("volUUID %s srcImg %s srvVol %s", volUUID, srcImgUUID,
What are you logging exactly? The message doesn't really message anything

Line 200:         # Return the metaId
Don't comment what you do. Also if you think it's necessary to express put it in a var named metaId

--
To view, visit http://gerrit.ovirt.org/3628
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e6b97c36b17f63773013e7d2eed2a57a600bedb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: [WIP] Remove the shared code from BlockVolume.create
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3628
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e6b97c36b17f63773013e7d2eed2a57a600bedb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Remove the shared code from BlockVolume.create

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Remove the shared code from BlockVolume.create
......................................................................

Patch Set 5: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3628
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e6b97c36b17f63773013e7d2eed2a57a600bedb
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Remove the shared code from BlockVolume.create

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Remove the shared code from BlockVolume.create
......................................................................

Patch Set 7: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3628
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e6b97c36b17f63773013e7d2eed2a57a600bedb
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Remove the shared code from BlockVolume.create

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Remove the shared code from BlockVolume.create
......................................................................

Patch Set 8: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3628
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e6b97c36b17f63773013e7d2eed2a57a600bedb
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Remove the shared code from BlockVolume.create

[Federico Simoncelli]

Federico Simoncelli has abandoned this change.

Change subject: Remove the shared code from BlockVolume.create
......................................................................

Patch Set 10: Abandoned

Squashed in: http://gerrit.ovirt.org/3627

--
To view, visit http://gerrit.ovirt.org/3628
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I4e6b97c36b17f63773013e7d2eed2a57a600bedb
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi