Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Fix vdsClient.py pep8 completely. ......................................................................
Fix vdsClient.py pep8 completely.
Change-Id: Ic5fa63330f30e76f259aa7edc78f97d911a7d5c3 Signed-off-by: Antoni S. Puimedon asegurap@redhat.com --- M vdsm_cli/vdsClient.py 1 file changed, 503 insertions(+), 487 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/9992/1
diff --git a/vdsm_cli/vdsClient.py b/vdsm_cli/vdsClient.py index c67e3fe..f07d6b3 100644 --- a/vdsm_cli/vdsClient.py +++ b/vdsm_cli/vdsClient.py @@ -346,8 +346,8 @@ if (len(args) > 4): params = self._parseDriveSpec(args[4])
- return self.ExecAndExit(self.s.setVmTicket(vmId, otp64, secs, - connAct, params)) + return self.ExecAndExit(self.s.setVmTicket(vmId, otp64, secs, connAct, + params))
def do_reset(self, args): vmId = args[0] @@ -653,7 +653,7 @@ password = args[2]
con = dict(id="", connection=ip, port=port, iqn="", portal="", - user=username, password=password) + user=username, password=password)
targets = self.s.discoverSendTargets(con) if targets['status']['code']: @@ -1164,10 +1164,10 @@ if status['status']['code']: return status['status']['code'], status['status']['message'] print "TASK: %s STATUS: %s RESULT: %s MESSAGE: '%s'" % ( - taskID, - status["taskStatus"]["taskState"], - status["taskStatus"]["taskResult"], - status["taskStatus"]["message"]) + taskID, + status["taskStatus"]["taskState"], + status["taskStatus"]["taskResult"], + status["taskStatus"]["message"]) print "%s" % status # TODO
return 0, '' @@ -1645,20 +1645,24 @@ def diskReplicateStart(self, args): vmUUID, spUUID, sdUUID, imgUUID, volUUID, dstSdUUID = args
- status = self.s.diskReplicateStart(vmUUID, {'poolID': spUUID, - 'domainID': sdUUID, 'imageID': imgUUID, 'volumeID': volUUID}, + status = self.s.diskReplicateStart( + vmUUID, + {'poolID': spUUID, 'domainID': sdUUID, 'imageID': imgUUID, + 'volumeID': volUUID}, {'poolID': spUUID, 'domainID': dstSdUUID, 'imageID': imgUUID, - 'volumeID': volUUID}) + 'volumeID': volUUID})
return status['status']['code'], status['status']['message']
def diskReplicateFinish(self, args): vmUUID, spUUID, sdUUID, imgUUID, volUUID, dstSdUUID = args
- status = self.s.diskReplicateFinish(vmUUID, {'poolID': spUUID, - 'domainID': sdUUID, 'imageID': imgUUID, 'volumeID': volUUID}, + status = self.s.diskReplicateFinish( + vmUUID, + {'poolID': spUUID, 'domainID': sdUUID, 'imageID': imgUUID, + 'volumeID': volUUID}, {'poolID': spUUID, 'domainID': dstSdUUID, 'imageID': imgUUID, - 'volumeID': volUUID}) + 'volumeID': volUUID})
return status['status']['code'], status['status']['message']
@@ -1669,81 +1673,79 @@ serv = service() commands = { 'create': (serv.do_create, - ('<configFile> [parameter=value, parameter=value, ' - '......]', - 'Creates new machine with the paremeters given in the' - ' command line overriding the ones in the config file', - 'Example with config file: vdsClient someServer create' - ' myVmConfigFile', - 'Example with no file : vdsClient someServer create' - ' /dev/null vmId=<uuid> memSize=256 ' - 'imageFile=someImage display=<vnc|qxl|qxlnc>', - 'Parameters list: r=required, o=optional', - 'r vmId=<uuid> : Unique identification for the ' - 'created VM. Any additional operation on the VM must ' - 'refer to this ID', - 'o vmType=<qemu/kvm> : Virtual machine technology - ' - 'if not given kvm is default', - 'o kvmEnable=<true/false> : run in KVM enabled mode ' - 'or full emulation - default is according to the VDS ' - 'capabilities', - 'r memSize=<int> : Memory to allocate for this ' - 'machine', - 'r macAddr=aa:bb:cc:dd:ee:ff : MAC address of the ' - 'machine', - 'r display=<vnc|qxl|qxlnc> : send the machine ' - 'display to vnc, spice, or spice with no ' - 'image compression', - 'o drive=pool:poolID,domain:domainID,image:imageID,' - 'volume:volumeID[,boot:true,format:cow] : disk image ' - 'by UUIDs', - 'o (deprecated) hda/b/c/d=<path> : Disk drive ' - 'images', - 'o floppy=<image> : Mount the specified Image as ' - 'floppy', - 'o cdrom=<path> : ISO image file to be mounted as ' - 'the powerup cdrom', - 'o boot=<c/d/n> : boot device - drive C or cdrom or ' - 'network', - 'o sysprepInf=/path/to/file: Launch with the ' - 'specified file as sysprep.inf in floppy', - #'o any parmeter=<any value> : parameter that is ' - #'not familiar is passed as is to the VM', - #' and displayed with ' - #'all other parameter. They can be used for ' - #'additional', - #' information the user ' - #'want to reserve with the machine' - 'o acpiEnable : If present will remove the default ' - '-no-acpi switch', - 'o qgaEnable : use qemu-ga as guest agent', - 'o tdf : If present will add the -rtc-td-hack ' - 'switch', - 'o irqChip : If false, add the -no-kvm-irqchip ' - 'switch', - 'o spiceSecureChannels : comma-separated list of ' - 'spice channel that will be encrypted', - 'o spiceMonitors : number of emulated screen heads', - 'o soundDevice : emulated sound device', - 'o launchPaused : If "true", start qemu paused', - 'o vmName : human-readable name of new VM', - 'o tabletEnable : If "true", enable tablet input', - 'o timeOffset : guest's start date, relative to ' - 'host's time, in seconds', - 'o smp : number of vcpus', - 'o smpCoresPerSocket, smpThreadsPerCore : vcpu ' - 'topology', - 'o keyboardLayout : language code of client ' - 'keyboard', - 'o cpuType : emulated cpu (with optional flags)', - 'o emulatedMachine : passed as qemu's -M', - 'o devices={name:val[, name:val, name:{name:val, ' - 'name:val}]} : add a fully specified device', - 'o cpuPinning={vcpuid:pinning} cpu pinning in ' - 'libvirt-like format. see ' - 'http://libvirt.org/formatdomain.html' - '#elementsCPUTuning' - )), + ('<configFile> [parameter=value, parameter=value, ......]', + 'Creates new machine with the paremeters given in the' + ' command line overriding the ones in the config file', + 'Example with config file: vdsClient someServer create' + ' myVmConfigFile', + 'Example with no file : vdsClient someServer create' + ' /dev/null vmId=<uuid> memSize=256 ' + 'imageFile=someImage display=<vnc|qxl|qxlnc>', + 'Parameters list: r=required, o=optional', + 'r vmId=<uuid> : Unique identification for the ' + 'created VM. Any additional operation on the VM must ' + 'refer to this ID', + 'o vmType=<qemu/kvm> : Virtual machine technology - ' + 'if not given kvm is default', + 'o kvmEnable=<true/false> : run in KVM enabled mode ' + 'or full emulation - default is according to the VDS ' + 'capabilities', + 'r memSize=<int> : Memory to allocate for this ' + 'machine', + 'r macAddr=aa:bb:cc:dd:ee:ff : MAC address of the ' + 'machine', + 'r display=<vnc|qxl|qxlnc> : send the machine ' + 'display to vnc, spice, or spice with no ' + 'image compression', + 'o drive=pool:poolID,domain:domainID,image:imageID,' + 'volume:volumeID[,boot:true,format:cow] : disk image ' + 'by UUIDs', + 'o (deprecated) hda/b/c/d=<path> : Disk drive ' + 'images', + 'o floppy=<image> : Mount the specified Image as ' + 'floppy', + 'o cdrom=<path> : ISO image file to be mounted as ' + 'the powerup cdrom', + 'o boot=<c/d/n> : boot device - drive C or cdrom or ' + 'network', + 'o sysprepInf=/path/to/file: Launch with the ' + 'specified file as sysprep.inf in floppy', + #'o any parmeter=<any value> : parameter that is ' + #'not familiar is passed as is to the VM', + #' and displayed with ' + #'all other parameter. They can be used for ' + #'additional', + #' information the user ' + #'want to reserve with the machine' + 'o acpiEnable : If present will remove the default ' + '-no-acpi switch', + 'o qgaEnable : use qemu-ga as guest agent', + 'o tdf : If present will add the -rtc-td-hack ' + 'switch', + 'o irqChip : If false, add the -no-kvm-irqchip ' + 'switch', + 'o spiceSecureChannels : comma-separated list of ' + 'spice channel that will be encrypted', + 'o spiceMonitors : number of emulated screen heads', + 'o soundDevice : emulated sound device', + 'o launchPaused : If "true", start qemu paused', + 'o vmName : human-readable name of new VM', + 'o tabletEnable : If "true", enable tablet input', + 'o timeOffset : guest's start date, relative to ' + 'host's time, in seconds', + 'o smp : number of vcpus', + 'o smpCoresPerSocket, smpThreadsPerCore : vcpu ' + 'topology', + 'o keyboardLayout : language code of client ' + 'keyboard', + 'o cpuType : emulated cpu (with optional flags)', + 'o emulatedMachine : passed as qemu's -M', + 'o devices={name:val[, name:val, name:{name:val, ' + 'name:val}]} : add a fully specified device', + 'o cpuPinning={vcpuid:pinning} cpu pinning in ' + 'libvirt-like format. see ' + 'http://libvirt.org/formatdomain.html#elementsCPUTuning' + )), 'vmUpdateDevice': (serv.vmUpdateDevice, ('<vmId> <devicespec>', 'Update a VM's device', @@ -1763,16 +1765,16 @@ 'if empty list.' )), 'hotplugNic': (serv.hotplugNic, - ('<vmId> <nicspec>', - 'Hotplug NIC to existing VM', - 'nicspec parameters list: r=required, o=optional', - 'r device: bridge|sriov|vnlink|bridgeless.', - 'r network: network name', - 'r macAddr: mac address', - 'r nicModel: pv|rtl8139|e1000', - 'o bootOrder: <int> - global boot order across ' - 'all bootable devices' - )), + ('<vmId> <nicspec>', + 'Hotplug NIC to existing VM', + 'nicspec parameters list: r=required, o=optional', + 'r device: bridge|sriov|vnlink|bridgeless.', + 'r network: network name', + 'r macAddr: mac address', + 'r nicModel: pv|rtl8139|e1000', + 'o bootOrder: <int> - global boot order across ' + 'all bootable devices' + )), 'hotunplugNic': (serv.hotunplugNic, ('<vmId> <nicspec>', 'Hotunplug NIC from existing VM', @@ -1821,49 +1823,47 @@ 'o optional: True|False' )), 'changeCD': (serv.do_changeCD, - ('<vmId> <fileName|drivespec>', - 'Changes the iso image of the cdrom' - )), + ('<vmId> <fileName|drivespec>', + 'Changes the iso image of the cdrom' + )), 'changeFloppy': (serv.do_changeFloppy, - ('<vmId> <fileName|drivespec>', - 'Changes the image of the floppy drive' - )), + ('<vmId> <fileName|drivespec>', + 'Changes the image of the floppy drive' + )), 'destroy': (serv.do_destroy, - ('<vmId>', - 'Stops the emulation and destroys the virtual machine.' - ' This is not a shutdown.' - )), + ('<vmId>', + 'Stops the emulation and destroys the virtual machine.' + ' This is not a shutdown.' + )), 'shutdown': (serv.do_shutdown, - ('<vmId> <timeout> <message>', - 'Stops the emulation and graceful shutdown the virtual' - ' machine.' - )), + ('<vmId> <timeout> <message>', + 'Stops the emulation and graceful shutdown the virtual' + ' machine.' + )), 'list': (serv.do_list, - ('[view] [vms:vmId1,vmId2]', - 'Lists all available machines on the specified ' - 'server.', - "Optional vms list, should start with 'vms:' and " - "follow with 'vmId1,vmId2,...'", - 'Optional views:', - ' "long" all available configuration info ' - '(Default).', - ' "table" table output with the fields: vmId, ' - 'vmName, Status and IP.', - ' "ids" all vmIds.' - )), + ('[view] [vms:vmId1,vmId2]', + 'Lists all available machines on the specified server.', + "Optional vms list, should start with 'vms:' and follow with" + " 'vmId1,vmId2,...'", + 'Optional views:', + ' "long" all available configuration info (Default).', + ' "table" table output with the fields: vmId, vmName, ' + 'Status and IP.', + ' "ids" all vmIds.' + )), 'pause': (serv.do_pause, - ('<vmId>', - 'Pauses the execution of the virtual machine without ' - 'termination' - )), + ('<vmId>', + 'Pauses the execution of the virtual machine without ' + 'termination' + )), 'continue': (serv.do_continue, - ('<vmId>', - 'Continues execution after of a paused machine' - )), + ('<vmId>', + 'Continues execution after of a paused machine' + )), 'reset': (serv.do_reset, - ('<vmId>', - 'Sends reset signal to the vm' - )), + ('<vmId>', + 'Sends reset signal to the vm' + )), 'setVmTicket': (serv.do_setVmTicket, ('<vmId> <password> <sec> [disconnect|keep|fail], ' '[params={}]', @@ -1875,27 +1875,27 @@ ' name:value,name:value' )), 'migrate': (serv.do_migrate, - ('vmId=<id> method=<offline|online> src=host:[port] ' - 'dst=host:[port]', - 'Migrate a desktop from src machine to dst host using ' - 'the specified ports' - )), + ('vmId=<id> method=<offline|online> src=host:[port] ' + 'dst=host:[port]', + 'Migrate a desktop from src machine to dst host using ' + 'the specified ports' + )), 'migrateStatus': (serv.do_mStat, ('<vmId>', - 'Check the progress of current outgoing migration' + 'Check the progress of current outgoing migration' )), 'migrateCancel': (serv.do_mCancel, - ('<vmId>', + ('<vmId>', '(not implemented) cancel machine migration' - )), + )), 'sendkeys': (serv.do_sendkeys, - ('<vmId> <key1> ...... <keyN>', - 'Send the key sequence to the vm' - )), + ('<vmId> <key1> ...... <keyN>', + 'Send the key sequence to the vm' + )), 'getVdsCapabilities': (serv.do_getCap, - ('', - 'Get Capabilities info of the VDS' - )), + ('', + 'Get Capabilities info of the VDS' + )), 'getVdsCaps': (serv.do_getCap, ('', 'Get Capabilities info of the VDS' @@ -1906,462 +1906,478 @@ )), 'getVmStats': (serv.do_getVmStats, ('<vmId>', - 'Get Statistics info on the VM' + 'Get Statistics info on the VM' )), 'getAllVmStats': (serv.do_getAllVmStats, - ('', - 'Get Statistics info for all existing VMs' - )), + ('', + 'Get Statistics info for all existing VMs' + )), 'getVGList': (serv.getVGList, - ('storageType', - 'List of all VGs.' - )), + ('storageType', + 'List of all VGs.' + )), 'getDeviceList': (serv.getDeviceList, - ('[storageType]', - 'List of all block devices (optionally - matching ' - 'storageType).' - )), + ('[storageType]', + 'List of all block devices (optionally - matching ' + 'storageType).' + )), 'getDeviceInfo': (serv.getDeviceInfo, - ('<dev-guid>', - 'Get block storage device info.' - )), + ('<dev-guid>', + 'Get block storage device info.' + )), 'getDevicesVisibility': (serv.getDevicesVisibility, - ('<devlist>', - 'Get visibility of each device listed' - )), + ('<devlist>', + 'Get visibility of each device listed' + )), 'getVGInfo': (serv.getVGInfo, - ('<vgUUID>', - 'Get info of VG' - )), + ('<vgUUID>', + 'Get info of VG' + )), 'createVG': (serv.createVG, - ('<sdUUID> <devlist> [force]', - 'Create a new VG from devices devlist (list of dev ' - 'GUIDs)' - )), + ('<sdUUID> <devlist> [force]', + 'Create a new VG from devices devlist (list of dev ' + 'GUIDs)' + )), 'removeVG': (serv.removeVG, - ('<vgUUID>', - 'remove the VG identified by its UUID' - )), + ('<vgUUID>', + 'remove the VG identified by its UUID' + )), 'extendStorageDomain': (serv.extendStorageDomain, - ('<sdUUID> <spUUID> <devlist>', - 'Extend the Storage Domain by adding devices devlist ' - '(list of dev GUIDs)' - )), + ('<sdUUID> <spUUID> <devlist>', + 'Extend the Storage Domain by adding devices' + ' devlist (list of dev GUIDs)' + )), 'discoverST': (serv.discoverST, ('ip[:port] [username password]', 'Discover the available iSCSI targetnames on a ' 'specified iSCSI portal' )), 'cleanupUnusedConnections': (serv.cleanupUnusedConnections, - ('', - 'Clean up unused iSCSI storage connections' - )), + ('', + 'Clean up unused iSCSI storage ' + 'connections' + )), 'connectStorageServer': (serv.connectStorageServer, - ('<server type> <spUUID> <conList (id=...,' - 'connection=server:/export_path,portal=...,' - 'port=...,iqn=...,user=...,password=...' - '[,initiatorName=...])>', - 'Connect to a storage low level entity (server)' - )), + ('<server type> <spUUID> <conList (id=...,' + 'connection=server:/export_path,portal=...,' + 'port=...,iqn=...,user=...,password=...' + '[,initiatorName=...])>', + 'Connect to a storage low level entity ' + '(server)' + )), 'validateStorageServerConnection': - (serv.validateStorageServerConnection, - ('<server type> <spUUID> <conList (id=...,' - 'connection=server:/export_path,portal=...,port=...' - ',iqn=...,user=...,password=...' - '[,initiatorName=...])>', - 'Validate that we can connect to a storage server' - )), + (serv.validateStorageServerConnection, + ('<server type> <spUUID> <conList (id=...,' + 'connection=server:/export_path,portal=...,port=...,iqn=...,' + 'user=...,password=...[,initiatorName=...])>', + 'Validate that we can connect to a storage server' + )), 'disconnectStorageServer': (serv.disconnectStorageServer, - ('<server type> <spUUID> <conList (id=...,' - 'connection=server:/export_path,portal=...,port=...' - ',iqn=...,user=...,password=...' - '[,initiatorName=...])>', - 'Disconnect from a storage low level entity (server)' - )), + ('<server type> <spUUID> <conList (id=...,' + 'connection=server:/export_path,' + 'portal=...,port=...,iqn=...,user=...,' + 'password=...[,initiatorName=...])>', + 'Disconnect from a storage low level ' + 'entity (server)' + )), 'spmStart': (serv.spmStart, - ('<spUUID> <prevID> <prevLVER> <recoveryMode> ' - '<scsiFencing> <maxHostID> <version>', - 'Start SPM functionality' - )), + ('<spUUID> <prevID> <prevLVER> <recoveryMode> ' + '<scsiFencing> <maxHostID> <version>', + 'Start SPM functionality' + )), 'spmStop': (serv.spmStop, - ('<spUUID>', - 'Stop SPM functionality' - )), + ('<spUUID>', + 'Stop SPM functionality' + )), 'getSpmStatus': (serv.getSpmStatus, - ('<spUUID>', - 'Get SPM status' - )), + ('<spUUID>', + 'Get SPM status' + )), 'acquireDomainLock': (serv.acquireDomainLock, - ('<spUUID> <sdUUID>', - 'acquire storage domain lock' - )), + ('<spUUID> <sdUUID>', + 'acquire storage domain lock' + )), 'releaseDomainLock': (serv.releaseDomainLock, - ('<spUUID> <sdUUID>', - 'release storage domain lock' - )), + ('<spUUID> <sdUUID>', + 'release storage domain lock' + )), 'fenceSpmStorage': (serv.fenceSpmStorage, - ('<spUUID> <prevID> <prevLVER> ', - 'fence SPM storage state' - )), + ('<spUUID> <prevID> <prevLVER> ', + 'fence SPM storage state' + )), 'updateVM': (serv.updateVM, - ("<spUUID> <vmList> ('vm'=vmUUID,'ovf'='...','" - "imglist'='imgUUID1+imgUUID2+...') [sdUUID]", - 'Update VM on pool or Backup domain' - )), + ("<spUUID> <vmList> ('vm'=vmUUID,'ovf'='...','" + "imglist'='imgUUID1+imgUUID2+...') [sdUUID]", + 'Update VM on pool or Backup domain' + )), 'upgradeStoragePool': (serv.upgradeStoragePool, - ("<spUUID> <targetVersion>", - 'Upgrade a pool to a new version (Requires a running ' - 'SPM)' - )), + ("<spUUID> <targetVersion>", + 'Upgrade a pool to a new version (Requires a ' + 'running SPM)' + )), 'removeVM': (serv.removeVM, - ("<spUUID> <vmUUID> [sdUUID]", - 'Remove VM from pool or Backup domain' - )), + ('<spUUID> <vmUUID> [sdUUID]', + 'Remove VM from pool or Backup domain' + )), 'reconstructMaster': (serv.reconstructMaster, - ('<spUUID> <poolName> <masterDom> ' - '<domDict>({sdUUID1=status,sdUUID2=status,...}) ' - '<masterVersion>, [<lockPolicy> ' - '<lockRenewalIntervalSec> <leaseTimeSec> ' - '<ioOpTimeoutSec> <leaseRetries>]', - 'Reconstruct master domain' - )), + ('<spUUID> <poolName> <masterDom> ' + '<domDict>({sdUUID1=status,sdUUID2=status,...})' + ' <masterVersion>, [<lockPolicy> ' + '<lockRenewalIntervalSec> <leaseTimeSec> ' + '<ioOpTimeoutSec> <leaseRetries>]', + 'Reconstruct master domain' + )), 'createStoragePool': (serv.createStoragePool, - ('<storage type> <spUUID> <poolName> <masterDom> ' - '<domList>(sdUUID1,sdUUID2,...) <masterVersion>, ' - '[<lockPolicy> <lockRenewalIntervalSec> ' - '<leaseTimeSec> <ioOpTimeoutSec> <leaseRetries>]', - 'Create new storage pool with single/multiple image ' - 'data domain' - )), + ('<storage type> <spUUID> <poolName> <masterDom>' + ' <domList>(sdUUID1,sdUUID2,...) ' + '<masterVersion>, [<lockPolicy> ' + '<lockRenewalIntervalSec> <leaseTimeSec> ' + '<ioOpTimeoutSec> <leaseRetries>]', + 'Create new storage pool with single/multiple ' + 'image data domain' + )), 'destroyStoragePool': (serv.destroyStoragePool, - ('<spUUID> <id> <scsi-key>', - 'Destroy storage pool' - )), + ('<spUUID> <id> <scsi-key>', + 'Destroy storage pool' + )), 'connectStoragePool': (serv.connectStoragePool, - ('<spUUID> <id> <scsi-key> [masterUUID] [masterVer]', - 'Connect a Host to specific storage pool' - )), + ('<spUUID> <id> <scsi-key> [masterUUID] ' + '[masterVer]', + 'Connect a Host to specific storage pool' + )), 'disconnectStoragePool': (serv.disconnectStoragePool, - ('<spUUID> <id> <scsi-key>', - 'Disconnect a Host from the specific storage pool' - )), + ('<spUUID> <id> <scsi-key>', + 'Disconnect a Host from the specific ' + 'storage pool' + )), 'refreshStoragePool': (serv.refreshStoragePool, - ('<spUUID> <masterDom> <masterVersion>', - 'Refresh storage pool' - )), + ('<spUUID> <masterDom> <masterVersion>', + 'Refresh storage pool' + )), 'setStoragePoolDescription': (serv.setStoragePoolDescription, - ('<spUUID> <descr>', - 'Set storage pool description' - )), + ('<spUUID> <descr>', + 'Set storage pool description' + )), 'getStoragePoolInfo': (serv.getStoragePoolInfo, - ('<spUUID>', - 'Get storage pool info' - )), + ('<spUUID>', + 'Get storage pool info' + )), 'createStorageDomain': (serv.createStorageDomain, - ('<storage type> <domain UUID> <domain name> <param> ' - '<domType> <version>', - 'Creates new storage domain' - )), + ('<storage type> <domain UUID> <domain name> ' + '<param> <domType> <version>', + 'Creates new storage domain' + )), 'setStorageDomainDescription': (serv.setStorageDomainDescription, - ('<domain UUID> <descr>', - 'Set storage domain description' - )), + ('<domain UUID> <descr>', + 'Set storage domain description' + )), 'validateStorageDomain': (serv.validateStorageDomain, - ('<domain UUID>', - 'Validate storage domain' - )), + ('<domain UUID>', + 'Validate storage domain' + )), 'activateStorageDomain': (serv.activateStorageDomain, - ('<domain UUID> <pool UUID>', - 'Activate a storage domain that is already a member ' - 'in a storage pool.' - )), + ('<domain UUID> <pool UUID>', + 'Activate a storage domain that is already ' + 'a member in a storage pool.' + )), 'deactivateStorageDomain': (serv.deactivateStorageDomain, - ('<domain UUID> <pool UUID> <new master domain UUID> ' - '<masterVer>', - 'Deactivate a storage domain. ' - )), + ('<domain UUID> <pool UUID> <new master ' + 'domain UUID> <masterVer>', + 'Deactivate a storage domain. ' + )), 'attachStorageDomain': (serv.attachStorageDomain, - ('<domain UUID> <pool UUID>', - 'Attach a storage domain to a storage pool.' - )), + ('<domain UUID> <pool UUID>', + 'Attach a storage domain to a storage pool.' + )), 'detachStorageDomain': (serv.detachStorageDomain, - ('<domain UUID> <pool UUID> <new master domain UUID> ' - '<masterVer>', - 'Detach a storage domain from a storage pool.' - )), + ('<domain UUID> <pool UUID> <new master domain' + ' UUID> <masterVer>', + 'Detach a storage domain from a storage pool.' + )), 'forcedDetachStorageDomain': (serv.forcedDetachStorageDomain, - ('<domain UUID> <pool UUID>', - 'Forced detach a storage domain from a storage pool.' - )), + ('<domain UUID> <pool UUID>', + 'Forced detach a storage domain from a ' + 'storage pool.' + )), 'formatStorageDomain': (serv.formatStorageDomain, - ('<domain UUID> [<autoDetach>]', - 'Format detached storage domain.' - )), + ('<domain UUID> [<autoDetach>]', + 'Format detached storage domain.' + )), 'getStorageDomainInfo': (serv.getStorageDomainInfo, - ('<domain UUID>', - 'Get storage domain info.' - )), + ('<domain UUID>', + 'Get storage domain info.' + )), 'getStorageDomainStats': (serv.getStorageDomainStats, - ('<domain UUID>', - 'Get storage domain statistics.' - )), + ('<domain UUID>', + 'Get storage domain statistics.' + )), 'getStorageDomainsList': (serv.getStorageDomainsList, - ('<pool UUID>', - 'Get storage domains list of pool or all domains if ' - 'pool omitted.' - )), + ('<pool UUID>', + 'Get storage domains list of pool or all ' + 'domains if pool omitted.' + )), 'createVolume': (serv.createVolume, - ('<sdUUID> <spUUID> <imgUUID> <size> <volFormat> ' - '<preallocate> <diskType> <newVolUUID> <descr> ' - '<srcImgUUID> <srcVolUUID>', - 'Creates new volume or snapshot' - )), + ('<sdUUID> <spUUID> <imgUUID> <size> <volFormat> ' + '<preallocate> <diskType> <newVolUUID> <descr> ' + '<srcImgUUID> <srcVolUUID>', + 'Creates new volume or snapshot' + )), 'extendVolume': (serv.extendVolume, - ('<sdUUID> <spUUID> <imgUUID> <volUUID> ' - '<new disk size>', - 'Extend volume (SAN only)' - )), + ('<sdUUID> <spUUID> <imgUUID> <volUUID> ' + '<new disk size>', + 'Extend volume (SAN only)' + )), 'uploadVolume': (serv.uploadVolume, - ('<sdUUID> <spUUID> <imgUUID> <volUUID> <srcPath> ' - '<size>', - 'Upload volume file into existing volume' - )), + ('<sdUUID> <spUUID> <imgUUID> <volUUID> <srcPath> ' + '<size>', + 'Upload volume file into existing volume' + )), 'getVolumePath': (serv.getVolumePath, - ('<sdUUID> <spUUID> <imgUUID> <volume uuid>', - 'Returns the path to the requested uuid' - )), + ('<sdUUID> <spUUID> <imgUUID> <volume uuid>', + 'Returns the path to the requested uuid' + )), 'setVolumeDescription': (serv.setVolumeDescription, - ('<sdUUID> <spUUID> <imgUUID> <volUUID> <Description>', - 'Sets a new description to the volume' - )), + ('<sdUUID> <spUUID> <imgUUID> <volUUID> ' + '<Description>', + 'Sets a new description to the volume' + )), 'setVolumeLegality': (serv.setVolumeLegality, - ('<sdUUID> <spUUID> <imgUUID> <volUUID> <Legality>', - 'Set volume legality (ILLEGAL/LEGAL).' - )), + ('<sdUUID> <spUUID> <imgUUID> <volUUID> ' + '<Legality>', + 'Set volume legality (ILLEGAL/LEGAL).' + )), 'deleteVolume': (serv.deleteVolume, - ('<sdUUID> <spUUID> <imgUUID> <volUUID>,...,<volUUID> ' - '<postZero> [<force>]', - 'Deletes an volume if its a leaf. Else returns error' - )), + ('<sdUUID> <spUUID> <imgUUID> <volUUID>,...,<volUUID>' + ' <postZero> [<force>]', + 'Deletes an volume if its a leaf. Else returns error' + )), 'deleteVolumeByDescr': (serv.deleteVolumeByDescr, - ('<part of description> <sdUUID> <spUUID> <imgUUID>', - 'Deletes list of volumes(only leafs) according to ' - 'their description' - )), + ('<part of description> <sdUUID> <spUUID> ' + '<imgUUID>', + 'Deletes list of volumes(only leafs) ' + 'according to their description' + )), 'getVolumeInfo': (serv.getVolumeInfo, - ('<sdUUID> <spUUID> <imgUUID> <volUUID>', - 'Returns all the volume details' - )), + ('<sdUUID> <spUUID> <imgUUID> <volUUID>', + 'Returns all the volume details' + )), 'getParent': (serv.getParent, - ('<sdUUID> <spUUID> <imgUUID> <Disk Image uuid>', - 'Returns the parent of the volume. Error if no parent' - ' exists' - )), + ('<sdUUID> <spUUID> <imgUUID> <Disk Image uuid>', + 'Returns the parent of the volume. Error if no parent' + ' exists' + )), 'getVolumesList': (serv.getVolumesList, - ('<sdUUID> <spUUID> [imgUUID]', - 'Returns list of volumes of imgUUID or sdUUID if ' - 'imgUUID absent' - )), + ('<sdUUID> <spUUID> [imgUUID]', + 'Returns list of volumes of imgUUID or sdUUID if ' + 'imgUUID absent' + )), 'getVolumeSize': (serv.getVolumeSize, - ('<sdUUID> <spUUID> <imgUUID> <volUUID>', - 'Returns the apparent size and the true size of the ' - 'volume (in bytes)' - )), + ('<sdUUID> <spUUID> <imgUUID> <volUUID>', + 'Returns the apparent size and the true size of the' + ' volume (in bytes)' + )), 'getFileList': (serv.getFileList, - ('<sdUUID> [pattern]', - 'Returns files list from ISO domain' - )), + ('<sdUUID> [pattern]', + 'Returns files list from ISO domain' + )), 'getIsoList': (serv.getIsoList, - ('<spUUID>', - 'Returns list of all .iso images in ISO domain' - )), + ('<spUUID>', + 'Returns list of all .iso images in ISO domain' + )), 'getFloppyList': (serv.getFloppyList, - ('<spUUID>', - 'Returns list of all .vfd images in ISO domain' - )), + ('<spUUID>', + 'Returns list of all .vfd images in ISO domain' + )), 'getImagesList': (serv.getImagesList, - ('<sdUUID>', - 'Get list of all images of specific domain' - )), + ('<sdUUID>', + 'Get list of all images of specific domain' + )), 'getImageDomainsList': (serv.getImageDomainsList, - ('<spUUID> <imgUUID> [datadomain=True]', - 'Get list of all data domains in the pool that ' - 'contains imgUUID' - )), + ('<spUUID> <imgUUID> [datadomain=True]', + 'Get list of all data domains in the pool ' + 'that contains imgUUID' + )), 'getConnectedStoragePoolsList': (serv.getConnectedStoragePoolsList, - ('', - 'Get storage pools list' - )), + ('', + 'Get storage pools list' + )), 'getTaskInfo': (serv.getTaskInfo, - ('<TaskID>', - 'get async task info' - )), + ('<TaskID>', + 'get async task info' + )), 'getAllTasksInfo': (serv.getAllTasksInfo, - ('', - 'get info of all async tasks' - )), + ('', + 'get info of all async tasks' + )), 'getTaskStatus': (serv.getTaskStatus, - ('<TaskID>', - 'get task status' - )), + ('<TaskID>', + 'get task status' + )), 'getAllTasksStatuses': (serv.getAllTasksStatuses, - ('', - 'list statuses of all async tasks' - )), + ('', + 'list statuses of all async tasks' + )), 'getAllTasks': (serv.getAllTasks, - ('[tags='']', - 'get status and information for all async tasks' - )), + ('[tags='']', + 'get status and information for all async tasks' + )), 'stopTask': (serv.stopTask, - ('<TaskID>', - 'stop async task' - )), + ('<TaskID>', + 'stop async task' + )), 'clearTask': (serv.clearTask, - ('<TaskID>', - 'clear async task' - )), + ('<TaskID>', + 'clear async task' + )), 'revertTask': (serv.revertTask, - ('<TaskID>', - 'revert async task' - )), + ('<TaskID>', + 'revert async task' + )), 'prepareForShutdown': (serv.prepareForShutdown, - ('', '' - )), + ('', '')), 'setLogLevel': (serv.do_setLogLevel, - ('<level> [logName][,logName]...', 'set log verbosity' - ' level (10=DEBUG, 50=CRITICAL' - )), + ('<level> [logName][,logName]...', 'set log verbosity' + ' level (10=DEBUG, 50=CRITICAL' + )), 'setMOMPolicy': (serv.do_setMOMPolicy, - ('<policyfile>', 'set MOM policy')), + ('<policyfile>', 'set MOM policy')), 'deleteImage': (serv.deleteImage, - ('<sdUUID> <spUUID> <imgUUID> [<postZero>] [<force>]', - 'Delete Image folder with all volumes.', - )), + ('<sdUUID> <spUUID> <imgUUID> [<postZero>] [<force>]', + 'Delete Image folder with all volumes.', + )), 'moveImage': (serv.moveImage, - ('<spUUID> <srcDomUUID> <dstDomUUID> <imgUUID> <vmUUID>' - ' <op = COPY_OP/MOVE_OP> [<postZero>] [ <force>]', - 'Move/Copy image between storage domains within same ' - 'storage pool' - )), + ('<spUUID> <srcDomUUID> <dstDomUUID> <imgUUID> <vmUUID>' + ' <op = COPY_OP/MOVE_OP> [<postZero>] [ <force>]', + 'Move/Copy image between storage domains within same ' + 'storage pool' + )), 'cloneImageStructure': (serv.cloneImageStructure, - ('<spUUID> <sdUUID> <imgUUID> <dstSdUUID>', - 'Clone an image structure from a source domain to a ' - 'destination domain within the same pool.' - )), + ('<spUUID> <sdUUID> <imgUUID> <dstSdUUID>', + 'Clone an image structure from a source ' + 'domain to a destination domain within the ' + 'same pool.' + )), 'syncImageData': (serv.syncImageData, - ('<spUUID> <sdUUID> <imgUUID> <dstSdUUID> <syncType>', - 'Synchronize image data between storage domains ' - 'within same pool.' - )), + ('<spUUID> <sdUUID> <imgUUID> <dstSdUUID> ' + '<syncType>', + 'Synchronize image data between storage domains ' + 'within same pool.' + )), 'moveMultiImage': (serv.moveMultiImage, - ('<spUUID> <srcDomUUID> <dstDomUUID> ' - '<imgList>({imgUUID=postzero,imgUUID=postzero,...})' - ' <vmUUID> [<force>]', - 'Move multiple images between storage domains within ' - 'same storage pool' - )), + ('<spUUID> <srcDomUUID> <dstDomUUID> ' + '<imgList>({imgUUID=postzero,' + 'imgUUID=postzero,...}) <vmUUID> [<force>]', + 'Move multiple images between storage domains ' + 'within same storage pool' + )), 'copyImage': (serv.copyImage, - ('<sdUUID> <spUUID> <vmUUID> <srcImgUUID> <srcVolUUID> ' - '<dstImgUUID> <dstVolUUID> <dstDescr> <dstSdUUID> ' - '<volType> <volFormat> <preallocate> [<postZero>] ' - '[<force>]', - 'Create new template/volume from VM.', - 'Do it by collapse and copy the whole chain ' - '(baseVolUUID->srcVolUUID)' - )), + ('<sdUUID> <spUUID> <vmUUID> <srcImgUUID> <srcVolUUID> ' + '<dstImgUUID> <dstVolUUID> <dstDescr> <dstSdUUID> ' + '<volType> <volFormat> <preallocate> [<postZero>] ' + '[<force>]', + 'Create new template/volume from VM.', + 'Do it by collapse and copy the whole chain ' + '(baseVolUUID->srcVolUUID)' + )), 'mergeSnapshots': (serv.mergeSnapshots, - ('<sdUUID> <spUUID> <vmUUID> <imgUUID> <Ancestor Image ' - 'uuid> <Successor Image uuid> [<postZero>]', - 'Merge images from successor to ancestor.', - 'The result is a image named as successor image and ' - 'contents the data of whole successor->ancestor chain' - )), + ('<sdUUID> <spUUID> <vmUUID> <imgUUID> <Ancestor ' + 'Image uuid> <Successor Image uuid> [<postZero>]', + 'Merge images from successor to ancestor.', + 'The result is a image named as successor image ' + 'and contents the data of whole successor->' + 'ancestor chain' + )), 'desktopLogin': (serv.desktopLogin, - ('<vmId> <domain> <user> <password>', - 'Login to vmId desktop using the supplied credentials' - )), + ('<vmId> <domain> <user> <password>', + 'Login to vmId desktop using the supplied ' + 'credentials' + )), 'desktopLogoff': (serv.desktopLogoff, - ('<vmId> <force>', - 'Lock user session. force should be set to true/false' - )), + ('<vmId> <force>', + 'Lock user session. force should be set to ' + 'true/false' + )), 'desktopLock': (serv.desktopLock, - ('<vmId>', + ('<vmId>', 'Logoff current user' - )), + )), 'sendHcCmd': (serv.sendHcCmd, - ('<vmId> <message>', - 'Sends a message to a specific VM through Hypercall ' - 'channel' - )), + ('<vmId> <message>', + 'Sends a message to a specific VM through Hypercall ' + 'channel' + )), 'hibernate': (serv.hibernate, - ('<vmId>', - 'Hibernates the desktop' - )), + ('<vmId>', + 'Hibernates the desktop' + )), 'monitorCommand': (serv.monitorCommand, - ('<vmId> <string>', - 'Send a string containing monitor command to the ' - 'desktop' - )), + ('<vmId> <string>', + 'Send a string containing monitor command to the ' + 'desktop' + )), 'getVmsInfo': (serv.do_getVmsInfo, - ('<spUUID> [<sdUUID> [vmList](vmId1,vmId2,...)]', - 'Return info of VMs from the pool or a backup domain ' - 'if its sdUUID is given. If vmList is also given, ' - 'return info for these VMs only.' - )), + ('<spUUID> [<sdUUID> [vmList](vmId1,vmId2,...)]', + 'Return info of VMs from the pool or a backup domain ' + 'if its sdUUID is given. If vmList is also given, ' + 'return info for these VMs only.' + )), 'getVmsList': (serv.do_getVmsList, - ('<spUUID> [sdUUID]', - 'Get list of VMs from the pool or domain if sdUUID ' - 'given. Run only from the SPM.' - )), + ('<spUUID> [sdUUID]', + 'Get list of VMs from the pool or domain if sdUUID ' + 'given. Run only from the SPM.' + )), 'addNetwork': (serv.do_addNetwork, ('bridge=<bridge> [vlan=<number>] [bond=<bond>] ' - 'nics=nic[,nic]', + 'nics=nic[,nic]', 'Add a new network to this vds.' )), 'delNetwork': (serv.do_delNetwork, ('bridge=<bridge> [vlan=<number>] [bond=<bond>] ' - 'nics=nic[,nic]', + 'nics=nic[,nic]', 'Remove a network (and parts thereof) from this vds.' )), 'editNetwork': (serv.do_editNetwork, ('oldBridge=<bridge> newBridge=<bridge> [vlan=<number>]' - ' [bond=<bond>] nics=nic[,nic]', + ' [bond=<bond>] nics=nic[,nic]', 'Replace a network with a new one.' )), 'setSafeNetworkConfig': (serv.do_setSafeNetworkConfig, - ('', - 'declare current network configuration as "safe"' - )), + ('', + 'declare current network configuration as ' + '"safe"' + )), 'fenceNode': (serv.do_fenceNode, ('<addr> <port> <agent> <user> <passwd> <action> ' - '[<secure> [<options>]] \n\t<action> is one of ' - '(status, on, off, reboot),\n\t<agent> is one of ' - '(rsa, ilo, ipmilan, drac5, etc)\n\t<secure> ' - '(true|false) may be passed to some agents', + '[<secure> [<options>]] \n\t<action> is one of ' + '(status, on, off, reboot),\n\t<agent> is one of ' + '(rsa, ilo, ipmilan, drac5, etc)\n\t<secure> ' + '(true|false) may be passed to some agents', 'send a fencing command to a remote node' )), 'repoStats': (serv.repoStats, ('', - "Get the the health status of the active domains" + 'Get the the health status of the active domains' )), 'snapshot': (serv.snapshot, - ('<vmId> <sdUUID> <imgUUID> <baseVolUUID> <volUUID>', - "Take a live snapshot" - )), + ('<vmId> <sdUUID> <imgUUID> <baseVolUUID> <volUUID>', + 'Take a live snapshot' + )), 'setBalloonTarget': (serv.setBalloonTarget, - ('<vmId> <target>', - "Set VM's balloon target" - )), + ('<vmId> <target>', + "Set VM's balloon target" + )), 'diskReplicateStart': (serv.diskReplicateStart, - ('<vmId> <spUUID> <sdUUID> <imgUUID> <volUUID> ' - '<dstSdUUID>', - "Start live replication to the destination domain" - )), + ('<vmId> <spUUID> <sdUUID> <imgUUID> <volUUID> ' + '<dstSdUUID>', + 'Start live replication to the destination ' + 'domain' + )), 'diskReplicateFinish': (serv.diskReplicateFinish, - ('<vmId> <spUUID> <sdUUID> <imgUUID> <volUUID> ' - '<dstSdUUID>', - "Start live replication to the destination domain" - )), + ('<vmId> <spUUID> <sdUUID> <imgUUID> <volUUID>' + ' <dstSdUUID>', + 'Start live replication to the destination ' + 'domain' + )), } if _glusterEnabled: commands.update(ge.getGlusterCmdDict(serv))
-- To view, visit http://gerrit.ovirt.org/9992 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ic5fa63330f30e76f259aa7edc78f97d911a7d5c3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix vdsClient.py pep8 completely. ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/338/ (1/2)
-- To view, visit http://gerrit.ovirt.org/9992 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic5fa63330f30e76f259aa7edc78f97d911a7d5c3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix vdsClient.py pep8 completely. ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/304/ (2/2)
-- To view, visit http://gerrit.ovirt.org/9992 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic5fa63330f30e76f259aa7edc78f97d911a7d5c3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix vdsClient.py pep8 completely. ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/304/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/338/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/9992 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic5fa63330f30e76f259aa7edc78f97d911a7d5c3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix vdsClient.py pep8 completely. ......................................................................
Patch Set 1: Verified
Output of pydiff antoni@nx01 ~/code/vdsm> gitpydiff HEAD checking vdsm_cli/vdsClient.py antoni@nx01 ~/code/vdsm>
-- To view, visit http://gerrit.ovirt.org/9992 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic5fa63330f30e76f259aa7edc78f97d911a7d5c3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Fix vdsClient.py pep8 completely. ......................................................................
Patch Set 1: Looks good to me, approved
Too bad for you, Toni - now git-blame thinks that you are in charge of this modules.
-- To view, visit http://gerrit.ovirt.org/9992 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic5fa63330f30e76f259aa7edc78f97d911a7d5c3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix vdsClient.py pep8 completely. ......................................................................
Fix vdsClient.py pep8 completely.
Change-Id: Ic5fa63330f30e76f259aa7edc78f97d911a7d5c3 Signed-off-by: Antoni S. Puimedon asegurap@redhat.com --- M vdsm_cli/vdsClient.py 1 file changed, 503 insertions(+), 487 deletions(-)
Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/9992 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ic5fa63330f30e76f259aa7edc78f97d911a7d5c3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix vdsClient.py pep8 completely. ......................................................................
Patch Set 2:
I know... I was thinking of including some hack in the git repo that if the blame ownership refers to a patch with the word pep8, to skip ownership to the previous modification.
-- To view, visit http://gerrit.ovirt.org/9992 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic5fa63330f30e76f259aa7edc78f97d911a7d5c3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org
-
asegurap＠redhat.com -
Dan Kenigsberg -
Jenkins CI RO