4 p.m.
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: pylint: storage.sd.SDManifest: declare special_volumes as the classmethod
it is
......................................................................
pylint: storage.sd.SDManifest: declare special_volumes as the classmethod it is
Change-Id: I205b03aeccf37986eebd0772799d886e9b750c7a
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/storage/sd.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/69343/1
diff --git a/vdsm/storage/sd.py b/vdsm/storage/sd.py
index bc59b3f..36ede36 100644
--- a/vdsm/storage/sd.py
+++ b/vdsm/storage/sd.py
@@ -332,6 +332,7 @@
self._domainLock = self._makeDomainLock()
self._external_leases_lock = rwlock.RWLock()
+ @classmethod
def special_volumes(cls, version):
"""
Return the special volumes managed by this storage domain.
--
To view, visit https://gerrit.ovirt.org/69343
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I205b03aeccf37986eebd0772799d886e9b750c7a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
5:27 a.m.
New subject: Change in vdsm[master]: pylint: fix storage.sd.SDManifest
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: fix storage.sd.SDManifest
......................................................................
Patch Set 6:
ci please build
--
To view, visit https://gerrit.ovirt.org/69343
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I205b03aeccf37986eebd0772799d886e9b750c7a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7:11 a.m.
New subject: Change in vdsm[master]: pylint: fix storage.sd.SDManifest
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: fix storage.sd.SDManifest
......................................................................
Patch Set 7: Verified+1
http://jenkins.ovirt.org/job/ovirt_master_system-tests_on_demand/30/
--
To view, visit https://gerrit.ovirt.org/69343
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I205b03aeccf37986eebd0772799d886e9b750c7a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7:12 a.m.
New subject: Change in vdsm[master]: pylint: fix storage.sd.SDManifest
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: fix storage.sd.SDManifest
......................................................................
Patch Set 7: Code-Review+2
copying score from ps2
--
To view, visit https://gerrit.ovirt.org/69343
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I205b03aeccf37986eebd0772799d886e9b750c7a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7:12 a.m.
New subject: Change in vdsm[master]: pylint: fix storage.sd.SDManifest
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pylint: fix storage.sd.SDManifest
......................................................................
pylint: fix storage.sd.SDManifest
declare special_volumes() as the classmethod it is
Change-Id: I205b03aeccf37986eebd0772799d886e9b750c7a
Bug-Url: https://bugzilla.redhat.com/1317429
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/storage/sd.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69343
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I205b03aeccf37986eebd0772799d886e9b750c7a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
2671
days inactive
2673
days old
vdsm-patches@lists.fedorahosted.org
4 comments
1 participants
participants (1)
-
Code Review