Change in vdsm[master]: walk around threading and pipe problem

Change in vdsm[master]: build: Add...

Change in vdsm[master]: Add...

xiawenc＠linux.vnet.ibm.com

Wednesday, 18 April 2012 Wed, 18 Apr '12

2:26 a.m.

Wenchao Xia has uploaded a new change for review. Change subject: walk around threading and pipe problem ...................................................................... walk around threading and pipe problem Calling subprocess.Popen and threading.Thread at the same time have race condition in Python 2.7.2, this patch added a lock to avoid this situation. If next release of Python fixed it, this could be removed Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Signed-off-by: wenchao xia <xiawenc(a)linux.vnet.ibm.com> --- M vdsm/betterThreading.py M vdsm/storage/misc.py 2 files changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/3638/1 -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Show replies by date

Dan Kenigsberg

Wednesday, 25 April Wed, 25 Apr

4:43 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Dan Kenigsberg has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 8: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Dan Kenigsberg

Monday, 30 April Mon, 30 Apr

1:28 p.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Dan Kenigsberg has submitted this change and it was merged. Change subject: workaround pipe and thread issue in python ...................................................................... workaround pipe and thread issue in python Calling subprocess.Popen and threading.Thread at the same time is not safe in Python v2.7.2. Running test case for several release, results are: Fedora16: v3.2.2 and v2.7.3 pass, v2.7.2 fail. Redhat6.2: v2.6.6 pass. This patch modify the spec file to avoid the fails. bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=814492 cpython issue tracker solving the problem: http://bugs.python.org/issue13156 Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Signed-off-by: wenchao xia <xiawenc(a)linux.vnet.ibm.com> --- M vdsm.spec.in 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Lei Li: Verified; Looks good to me, but someone else must approve Saggi Mizrahi: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Dan Kenigsberg

1:28 p.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Dan Kenigsberg has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 8: Ok, I think we've waited enough for objections. Thanks! -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

smizrahi＠redhat.com

12:31 p.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Saggi Mizrahi has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 8: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

lilei＠linux.vnet.ibm.com

Thursday, 26 April Thu, 26 Apr

1:28 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Lei Li has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 8: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

abaron＠redhat.com

Tuesday, 24 April Tue, 24 Apr

4:33 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Ayal Baron has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 7: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm.spec.in Line 47: Requires: python which if which is not needed then why don't we get rid of it entirely? if it is needed then it is needed always and shouldn't be part of the if. -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

shaohef＠linux.vnet.ibm.com

4:23 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

ShaoHe Feng has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 7: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Dan Kenigsberg

3:27 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Dan Kenigsberg has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 7: Looks good to me, but someone else must approve Please send an email to vdsm-devel about this change - it is going to disturb a lot of people, so I would like to inform them in advance. -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

xiawenc＠linux.vnet.ibm.com

3:16 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Wenchao Xia has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 5: Tested on el6.2 with python 2.6.6, unable to produce it, my mistake. Adjusted the spec file and rebased. -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Dan Kenigsberg

1:30 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Dan Kenigsberg has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 5: Wenchao Xia, have you reproduced the bug in el6's Python 2.6.? If so, it should be fixed there, too. Not only in Fedora. If this is the case, please clone rhbz#814492 to RHEL6! -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

xiawenc＠linux.vnet.ibm.com

12:45 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Wenchao Xia has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 5: Since el6 have no python2.7.3 available, how should I deal with it? My opinion is adding a lock or null lock depends on the python version at runtime. -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

xiawenc＠linux.vnet.ibm.com

Monday, 23 April Mon, 23 Apr

3:04 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Wenchao Xia has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 5: (1 inline comment) .................................................... File vdsm.spec.in Line 36: Requires: python >= 2.7.3 OK. Then for el6 system, so far the solution I can think about are: 1 add a lock on it, similar to patch set 5. 2 or force user to update python himself in .spec file. Could u give some suggestion about it? -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Dan Kenigsberg

2:43 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Dan Kenigsberg has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 5: (1 inline comment) .................................................... File vdsm.spec.in Line 36: Requires: python >= 2.7.3 el6 will NOT have python 2.7.3. rhel6 is a stable distribution that does not take new upstream versions on a minor version change. the request for python version should be specific to Fedora. -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

xiawenc＠linux.vnet.ibm.com

1:04 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Wenchao Xia has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 5: (1 inline comment) comments reply in lines. .................................................... File vdsm.spec.in Line 36: Requires: python >= 2.7.3 I thought "Requires: python which" means no requirement for python version, so I made a request for it. "%else Requires: python" make issue still happen, is that acceptable? fired a bug to confirm whether el6 have the package: https://bugzilla.redhat.com/show_bug.cgi?id=815176 -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Dan Kenigsberg

Saturday, 21 April Sat, 21 Apr

11:19 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Dan Kenigsberg has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 5: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Sheldon Feng <shaohef(a)linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Dan Kenigsberg

9:28 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Dan Kenigsberg has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 5: (1 inline comment) .................................................... File vdsm.spec.in Line 36: Requires: python >= 2.7.3 was the removal of "which" intentional? it may well be valid, but unrelated to this python patch. more importantly - please make sure el6 already has this version of python, or have only %if !0%{?rhel} Requires: python >= 2.7.3 %else Requires: python %end -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Sheldon Feng <shaohef(a)linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

shaohef＠linux.vnet.ibm.com

Friday, 20 April Fri, 20 Apr

5 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Sheldon Feng has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 5: Verified; Looks good to me, but someone else must approve (1 inline comment) tested. it can work. .................................................... File vdsm.spec.in Line 36: Requires: python >= 2.7.3 this bug has been fixed on python 2.7.3. what about 2.7.2 and before version. Will it be backported on 2.7.2 and before? -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Sheldon Feng <shaohef(a)linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

xiawenc＠linux.vnet.ibm.com

3:59 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Wenchao Xia has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 3: adjusted the codes according to comments. -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Dan Kenigsberg

3:44 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Dan Kenigsberg has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 3: I would prefer that you didn't submit this Given https://bugzilla.redhat.com/show_bug.cgi?id=814492#c1 saying that python 2.7.3 is available for Fedora, I'd prefer to replace this patch by a simple Requires: python > 2.7.3 in the Fedora section of our spec file. -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

xiawenc＠linux.vnet.ibm.com

1:44 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Wenchao Xia has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 3: Please ignore patch set 3, some codes need to be adjusted. -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

xiawenc＠linux.vnet.ibm.com

1:41 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Wenchao Xia has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 2: Sure, fired a new bug in Fedora bugzilla. Also the patch code was changed to automatically adjust according to python version, for that test passed on Python v2.7.3 which was released a few days ago. -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Dan Kenigsberg

Thursday, 19 April Thu, 19 Apr

11:10 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Dan Kenigsberg has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 2: (6 inline comments) note my former comment about the python bug. .................................................... File vdsm/betterThreading.py Line 108: ThreadPipeLock = threading.Lock() instances begin with lower case letter, Classes with upper case. Line 115: self.lockPipe = ThreadPipeLock private data members should begin with _ Line 118: self.lockPipe.acquire() use "with" Line 122: threading.Thread = vdsmThread; please monkey-patch only pythons with this bug? .................................................... File vdsm/storage/misc.py Line 190: ThreadPipeLock = betterThreading.ThreadPipeLock that's done nicer with from betterThreading import threadPipeLock Line 220: ThreadPipeLock.acquire() better use "with". I hate to deadlock due to a silly p.stdout.write exception. -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Dan Kenigsberg

4:39 a.m.

New subject: Change in vdsm[master]: workaround pipe and thread issue in python

Dan Kenigsberg has posted comments on this change. Change subject: workaround pipe and thread issue in python ...................................................................... Patch Set 2: I would prefer that you didn't submit this Wenchao, you are working around a Python bug. The commit message should state which bug it is. Please open a Python bug of Fedora's BZ if needed. -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Dan Kenigsberg

2:11 a.m.

Dan Kenigsberg has posted comments on this change. Change subject: walk around threading and pipe problem ...................................................................... Patch Set 1: Wenchao Xia, please add this information to the commit message - and open a Python bug for Fedora. Maybe we can get the 3.2 solution (haven't give it a glance yet, sorry) backported to Fedora. -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

xiawenc＠linux.vnet.ibm.com

1:50 a.m.

Wenchao Xia has posted comments on this change. Change subject: walk around threading and pipe problem ...................................................................... Patch Set 1: added an attachment in bug808853 https://bugzilla.redhat.com/show_bug.cgi?id=808853 Thread_Pipe_Test.py, a test python file to reproduce it without vdsm. Running it about 10 times should result in thread 1 hanging. I am trying to build latest python release, so can't fire a bug in python issue tracker now. But there are some discuss about subprocess issue there: http://bugs.python.org/issue2320, It is similar to what I observed, hangs on a thread calling subprocess pipe, conclusion is it is fixed in python 3.2, but not python 2.7. My test case is that one thread hanging at subprocess pipe call while another thread call start(). So more validation is needed on python 3.2 to see if it covers the situation. -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Dan Kenigsberg

Wednesday, 18 April Wed, 18 Apr

6:57 a.m.

Dan Kenigsberg has posted comments on this change. Change subject: walk around threading and pipe problem ...................................................................... Patch Set 1: I would prefer that you didn't submit this (3 inline comments) this is scary... I am a bit reluctant to take such an intrusive patch in order to work around a supposed serious bug in Python. Could you find a reproducer for the bug outside of Vdsm? I must require that there is a Python bug# in this commit message - otherwise we would never know when to remove this code. .................................................... Commit Message Line 7: walk around threading and pipe problem as a non-English-speaker to another: the term is "workaround". Line 9: Calling subprocess.Popen and threading.Thread at the same time have race condition in Python 2.7.2, this patch added shorter lines, please... they break badly on my terminal. .................................................... File vdsm/betterThreading.py Line 108: import storage.misc betterThreading must not depend on the rest of vdsm. -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

abaron＠redhat.com

6:05 a.m.

Ayal Baron has posted comments on this change. Change subject: walk around threading and pipe problem ...................................................................... Patch Set 1: I would prefer that you didn't submit this (6 inline comments) ][ .................................................... File vdsm/betterThreading.py Line 115: self.lockPipe = storage.misc.ThreadPipeLock I believe threadPipeLock should be defined here and imported in storage.misc, not the other way around. .................................................... File vdsm/storage/misc.py Line 79: ThreadPipeLock = threading.Lock() s/Thread/thread/ Line 220: with disabledGcBlock: why not: with ThreadPipeLock, disabledGcBlock: Line 226: trailing spaces are frowned upon. Line 231: ThreadPipeLock.release() redundant if used with "with" as above Line 248: ThreadPipeLock.release() redundant if used with "with" as above -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

xiawenc＠linux.vnet.ibm.com

2:33 a.m.

Wenchao Xia has posted comments on this change. Change subject: walk around threading and pipe problem ...................................................................... Patch Set 1: Related bugzillar: https://bugzilla.redhat.com/show_bug.cgi?id=808853 What vdsm shows is that if you delete /rhev/data-center/ and reboot vdsm, /rhev/data-center/hsm-task is not always created, which happens because the thread try creating it hangs. -- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

4441

days inactive

4453

days old

vdsm-patches@lists.fedorahosted.org

Manage subscription

28 comments

6 participants

tags (0)

participants (6)

abaron＠redhat.com
Dan Kenigsberg
lilei＠linux.vnet.ibm.com
shaohef＠linux.vnet.ibm.com
smizrahi＠redhat.com
xiawenc＠linux.vnet.ibm.com

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

Change in vdsm[master]: walk around threading and pipe problem