Change in vdsm[master]: mailbox: daemonize the hsm mailbox thread

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: mailbox: daemonize the hsm mailbox thread
......................................................................

mailbox: daemonize the hsm mailbox thread

In order to successfully complete a prepareForShutdown command
instead of waiting for a faulty mailbox thread to end, the thread
has been daemonized.

Change-Id: I416b42f46e67cecedbcd0ec4ead069279dd6935b
Signed-off-by: Federico Simoncelli 
---
M vdsm/storage/storage_mailbox.py
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/9559/1

diff --git a/vdsm/storage/storage_mailbox.py b/vdsm/storage/storage_mailbox.py
index c74fccc..991509f 100644
--- a/vdsm/storage/storage_mailbox.py
+++ b/vdsm/storage/storage_mailbox.py
@@ -243,6 +243,7 @@
         self._msgCounter = 0
         self._sendMail() # Clear outgoing mailbox
         threading.Thread.__init__(self)
+        self.daemon = True
         self.start()

def _initMailbox(self):

--
To view, visit http://gerrit.ovirt.org/9559
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I416b42f46e67cecedbcd0ec4ead069279dd6935b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: mailbox: daemonize the hsm mailbox thread
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/231/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9559
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I416b42f46e67cecedbcd0ec4ead069279dd6935b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: mailbox: daemonize the hsm mailbox thread
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/197/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9559
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I416b42f46e67cecedbcd0ec4ead069279dd6935b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: mailbox: daemonize the hsm mailbox thread
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/197/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/231/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9559
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I416b42f46e67cecedbcd0ec4ead069279dd6935b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Haim Ateya 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: oVirt Jenkins CI Server

Shu Ming has posted comments on this change.

Change subject: mailbox: daemonize the hsm mailbox thread
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 6: 
Line 7: mailbox: daemonize the hsm mailbox thread
Line 8: 
Line 9: In order to successfully complete a prepareForShutdown command
Line 10: instead of waiting for a faulty mailbox thread to end, the thread
Not sure If I understand these commends.  The prepareForShutdown command is a command to shutdown host or shutdown guest? When will the mailbox thread be faulty?
Line 11: has been daemonized.
Line 12: 
Line 13: Change-Id: I416b42f46e67cecedbcd0ec4ead069279dd6935b

--
To view, visit http://gerrit.ovirt.org/9559
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I416b42f46e67cecedbcd0ec4ead069279dd6935b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Haim Ateya 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: mailbox: daemonize the hsm mailbox thread
......................................................................

Patch Set 1: Looks good to me, approved

(1 inline comment)

....................................................
Commit Message
Line 6: 
Line 7: mailbox: daemonize the hsm mailbox thread
Line 8: 
Line 9: In order to successfully complete a prepareForShutdown command
Line 10: instead of waiting for a faulty mailbox thread to end, the thread
prepareForShutdown tries to shut down vdsm process. It is called on SIGTERM.

mailbox thread can block if it tries to create files on an inaccessible storage.
Line 11: has been daemonized.
Line 12: 
Line 13: Change-Id: I416b42f46e67cecedbcd0ec4ead069279dd6935b

--
To view, visit http://gerrit.ovirt.org/9559
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I416b42f46e67cecedbcd0ec4ead069279dd6935b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Haim Ateya 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: mailbox: daemonize the hsm mailbox thread
......................................................................

Patch Set 1: I would prefer that you didn't submit this

Let's hold this patch for a little more. We might need to daemonize also another thread (the temporary hsm storageRefresh that could get stuck on _connectStoragePool).

--
To view, visit http://gerrit.ovirt.org/9559
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I416b42f46e67cecedbcd0ec4ead069279dd6935b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Haim Ateya 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: thread: daemonize HSM_MailMonitor and storageRefresh

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: thread: daemonize HSM_MailMonitor and storageRefresh
......................................................................

Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/9559
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I416b42f46e67cecedbcd0ec4ead069279dd6935b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Haim Ateya 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: thread: daemonize HSM_MailMonitor and storageRefresh

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: thread: daemonize HSM_MailMonitor and storageRefresh
......................................................................

Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/9559
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I416b42f46e67cecedbcd0ec4ead069279dd6935b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Haim Ateya 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: thread: daemonize HSM_MailMonitor and storageRefresh

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: thread: daemonize HSM_MailMonitor and storageRefresh
......................................................................

thread: daemonize HSM_MailMonitor and storageRefresh

In order to successfully complete the prepareForShutdown command
some additional threads have been switched to daemon.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=880961
Change-Id: I416b42f46e67cecedbcd0ec4ead069279dd6935b
Signed-off-by: Federico Simoncelli 
---
M vdsm/storage/hsm.py
M vdsm/storage/storage_mailbox.py
2 files changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Federico Simoncelli: Verified
  Dan Kenigsberg: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/9559
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I416b42f46e67cecedbcd0ec4ead069279dd6935b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Haim Ateya 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: oVirt Jenkins CI Server