Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
.................................................... File vdsm/supervdsmServer Line 101: KB = 2 ** 10 Line 102: TEST_BUFF_LEN = 4 * KB Line 103: Line 104: Line 105: def getHardwareInfoStructurePPC64(): Here is not the location for specific implementation, as we don't put the dmidecodeUtil code and other api logic in this file. This file is dedicated only to declare supervdsm api and startup logic, please move it to external package.
I prefer adding it to dmidecodeUtil.py and change the name to hardwareInfoUtil or something in that direction Line 106: infoStructure = {'systemProductName': 'unavailable', Line 107: 'systemSerialNumber': 'unavailable', Line 108: 'systemFamily': 'unavailable', Line 109: 'systemVersion': 'unavailable',
vdsm-patches@lists.fedorahosted.org