Change in vdsm[master]: vdsm: Hardware information about POWER hosts

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: Hardware information about POWER hosts
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

....................................................
File vdsm/supervdsmServer
Line 101: KB = 2 ** 10
Line 102: TEST_BUFF_LEN = 4 * KB
Line 103: 
Line 104: 
Line 105: def getHardwareInfoStructurePPC64():
Here is not the location for specific implementation, as we don't put the
dmidecodeUtil code and other api logic in this file. This file is dedicated only to
declare supervdsm api and startup logic, please move it to external package.

I prefer adding it to dmidecodeUtil.py  and change the name to hardwareInfoUtil or
something in that direction
Line 106:     infoStructure = {'systemProductName': 'unavailable',
Line 107:                      'systemSerialNumber': 'unavailable',
Line 108:                      'systemFamily': 'unavailable',
Line 109:                      'systemVersion': 'unavailable',


-- 
To view, visit http://gerrit.ovirt.org/17417
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ec8c92dbca5837aacd299555d34d97931d7a1f0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes