Change in vdsm[master]: vdsmd: do not swallow libvirt error

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: vdsmd: do not swallow libvirt error
......................................................................

vdsmd: do not swallow libvirt error

Recently I've seen multiple cases of vdsm not starting up with a vague
error "Failed to define network filters on libvirt", when the underlying
issue was that libvirt has crashed.

It's better to have a line or two of log noise, in order to see that
libvirt could not have been reached.

Change-Id: I6a91061f52ec4eff24dd1e10f525fd3fed9185ef
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm/vdsmd.init.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/13909/1

diff --git a/vdsm/vdsmd.init.in b/vdsm/vdsmd.init.in
index dd1d65b..ba98e53 100755
--- a/vdsm/vdsmd.init.in
+++ b/vdsm/vdsmd.init.in
@@ -474,7 +474,7 @@
        return $ret_val
     fi
 
-    python @VDSMDIR(a)/nwfilter.pyc > /dev/null 2>&1
+    python @VDSMDIR(a)/nwfilter.pyc
     ret_val=$?
     if [ $ret_val -ne 0 ]
     then


--
To view, visit http://gerrit.ovirt.org/13909
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a91061f52ec4eff24dd1e10f525fd3fed9185ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsmd: do not swallow libvirt error
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2017/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1961/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/13909
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a91061f52ec4eff24dd1e10f525fd3fed9185ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Zhou Zheng Sheng has posted comments on this change.

Change subject: vdsmd: do not swallow libvirt error
......................................................................


Patch Set 1: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/13909
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a91061f52ec4eff24dd1e10f525fd3fed9185ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsmd: do not swallow libvirt error
......................................................................


vdsmd: do not swallow libvirt error

Recently I've seen multiple cases of vdsm not starting up with a vague
error "Failed to define network filters on libvirt", when the underlying
issue was that libvirt has crashed.

It's better to have a line or two of log noise, in order to see that
libvirt could not have been reached.

Change-Id: I6a91061f52ec4eff24dd1e10f525fd3fed9185ef
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm/vdsmd.init.in
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Moti Asayag: Looks good to me, but someone else must approve
  Zhou Zheng Sheng: Verified; Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/13909
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6a91061f52ec4eff24dd1e10f525fd3fed9185ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsmd: do not swallow libvirt error
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/13909
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a91061f52ec4eff24dd1e10f525fd3fed9185ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Moti Asayag has posted comments on this change.

Change subject: vdsmd: do not swallow libvirt error
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
Commit Message
Line 9: Recently I've seen multiple cases of vdsm not starting up with a vague
Line 10: error "Failed to define network filters on libvirt", when the
underlying
Line 11: issue was that libvirt has crashed.
Line 12: 
Line 13: It's better to have a line or two of log noise, in order to see that
I'm not sure it will be just a couple lines rather than a full stack trace.
However, getting more information for the failure cause is better then a generic message.
Line 14: libvirt could not have been reached.
Line 15: 
Line 16: Change-Id: I6a91061f52ec4eff24dd1e10f525fd3fed9185ef


--
To view, visit http://gerrit.ovirt.org/13909
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a91061f52ec4eff24dd1e10f525fd3fed9185ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsmd: do not swallow libvirt error
......................................................................


Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2017/ (2/2)

--
To view, visit http://gerrit.ovirt.org/13909
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a91061f52ec4eff24dd1e10f525fd3fed9185ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsmd: do not swallow libvirt error
......................................................................


Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1961/ (1/2)

--
To view, visit http://gerrit.ovirt.org/13909
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a91061f52ec4eff24dd1e10f525fd3fed9185ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server