Change in vdsm[master]: Skip broken tests feature

Saggi Mizrahi has uploaded a new change for review.

Change subject: Skip broken tests feature
......................................................................

Skip broken tests feature

We can't have broken tests upstream, it confuses people who write
patches and makes them think they broke the functionality.

Add this to tests you know are broken to help others

Change-Id: Ia380b2a5f5027e88926f61f4a762c1afec9f0203
Signed-off-by: Saggi Mizrahi 
---
M tests/alignmentScanTests.py
M tests/testValidation.py
2 files changed, 12 insertions(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/3966/1
--
To view, visit http://gerrit.ovirt.org/3966
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia380b2a5f5027e88926f61f4a762c1afec9f0203
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Skip broken tests feature
......................................................................

Patch Set 3:

I'd prefer to require whomever uses this, to state WHAT's broken, point to BZ, whatever.

--
To view, visit http://gerrit.ovirt.org/3966
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia380b2a5f5027e88926f61f4a762c1afec9f0203
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

Wenchao Xia has posted comments on this change.

Change subject: Skip broken tests feature
......................................................................

Patch Set 7:

could u give an example in the commit message about how to use the new function?

--
To view, visit http://gerrit.ovirt.org/3966
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia380b2a5f5027e88926f61f4a762c1afec9f0203
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Wenchao Xia

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Skip broken tests feature
......................................................................

Patch Set 7: I would prefer that you didn't submit this

it would be nicer for whomever uses this decorated to specify what is broken, and why. Otherwise, we are just hiding infor when we swallow the exception.

--
To view, visit http://gerrit.ovirt.org/3966
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia380b2a5f5027e88926f61f4a762c1afec9f0203
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Wenchao Xia

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Skip broken tests feature
......................................................................

Patch Set 8:

Build Successful

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/485/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/3966
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia380b2a5f5027e88926f61f4a762c1afec9f0203
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Wenchao Xia 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Skip broken tests feature
......................................................................

Patch Set 8: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3966
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia380b2a5f5027e88926f61f4a762c1afec9f0203
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Wenchao Xia 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Skip broken tests feature
......................................................................

Patch Set 8: Verified

--
To view, visit http://gerrit.ovirt.org/3966
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia380b2a5f5027e88926f61f4a762c1afec9f0203
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Wenchao Xia 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Skip broken tests feature
......................................................................

Skip broken tests feature

We can't have broken tests upstream, it confuses people who write
patches and makes them think they broke the functionality.

Add this to tests you know are broken to help others

Change-Id: Ia380b2a5f5027e88926f61f4a762c1afec9f0203
Signed-off-by: Saggi Mizrahi 
---
M tests/configNetworkTests.py
M tests/testValidation.py
2 files changed, 17 insertions(+), 1 deletion(-)

Approvals:
  Dan Kenigsberg: Verified
  Igor Lvovsky: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3966
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia380b2a5f5027e88926f61f4a762c1afec9f0203
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Wenchao Xia 
Gerrit-Reviewer: oVirt Jenkins CI Server