Dan Kenigsberg has posted comments on this change.
Change subject: systemd: set KillMode to process for vdsmd
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/40183/2/init/systemd/vdsmd.service.in
File init/systemd/vdsmd.service.in:
Line 19: User=@VDSMUSER@
Line 20: Group=@VDSMGROUP@
Line 21: PermissionsStartOnly=true
Line 22: TimeoutStopSec=@SERVICE_STOP_TIMEOUT@
Line 23: KillMode=process
ioprocess is killed by vdsm on sigterm, not by systemctl.
vdsm
sub-processes that must terminate when vdsm crashes are started with deathSignal=SIGTERM.
The only problem with this patch, is that it may expose bugs where we forget to use this
mechanism. But that's not really a problem, since we should fix the exposed bugs.
IIRC ioprocess uses the same mechanism (but I am not sure - better ask ykaplan or
ybronheim). In any case, it SHOULD, or else stale processes would live forever in case
vdsm crashes or SIGKILLed.
Line 24:
Line 25: [Install]
--
To view, visit
https://gerrit.ovirt.org/40183
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc0d7a6db7c59bbddbcd2a7dff8e2379802f51f5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Vijay Bellur <vbellur(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes