Change in vdsm[master]: virt: dev: implement from_xml for SmartcardDevice

Francesco Romani has uploaded a new change for review.

Change subject: virt: dev: implement from_xml for SmartcardDevice
......................................................................

virt: dev: implement from_xml for SmartcardDevice

Change-Id: I395c49d1cd9af04527840a7d5aaf853d35aa122d
Signed-off-by: Francesco Romani <fromani(a)redhat.com&gt;
---
M vdsm/virt/vm.py
1 file changed, 5 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/33753/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index e340ed0..a6e68ae 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4820,19 +4820,18 @@
             if not x.getElementsByTagName('address'):
                 continue
 
-            address = vmxml.device_address(x)
-            alias =
x.getElementsByTagName('alias')[0].getAttribute('name')
+            dev = SmartCardDevice.from_xml(x)
 
             for dev in self._devices[SMARTCARD_DEVICES]:
                 if not hasattr(dev, 'address'):
-                    dev.address = address
-                    dev.alias = alias
+                    dev.address = dev.address
+                    dev.alias = dev.alias
 
             for dev in self.conf['devices']:
                 if dev['device'] == SMARTCARD_DEVICES and \
                         not dev.get('address'):
-                    dev['address'] = address
-                    dev['alias'] = alias
+                    dev['address'] = dev.address
+                    dev['alias'] = dev.alias
 
     def _getUnderlyingWatchdogDeviceInfo(self):
         """


-- 
To view, visit http://gerrit.ovirt.org/33753
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I395c49d1cd9af04527840a7d5aaf853d35aa122d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: dev: implement from_xml for SmartcardDevice
......................................................................


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11800/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12746/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1719/ : There was an
infra issue, please contact infra(a)ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12589/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/33753
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I395c49d1cd9af04527840a7d5aaf853d35aa122d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: dev: implement from_xml for SmartcardDevice
......................................................................


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13585/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14542/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14374/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2089/ : There was an
infra issue, please contact infra(a)ovirt.org

-- 
To view, visit http://gerrit.ovirt.org/33753
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I395c49d1cd9af04527840a7d5aaf853d35aa122d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Francesco Romani has abandoned this change.

Change subject: virt: dev: implement from_xml for SmartcardDevice
......................................................................


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/33753
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I395c49d1cd9af04527840a7d5aaf853d35aa122d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org

automation(a)ovirt.org has posted comments on this change.

Change subject: virt: dev: implement from_xml for SmartcardDevice
......................................................................


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/33753
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I395c49d1cd9af04527840a7d5aaf853d35aa122d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No