From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pylint: Check changed modules in check-patch
......................................................................
pylint: Check changed modules in check-patch
Add pylint-diff target checking the modules modified by this patch.
Since this check is fast enough, we can run it for every patch in
check-patch.sh.
Since pylint will fail now for many modules, we do not fail the build
yet. When the current code is pylint-clean we can start failing the
build if a new error is detected.
Timing pylint and pylint-diff for typical patch:
$ time make pylint
...
real 1m31.133s
user 1m29.934s
sys 0m0.849s
$ time make pylint-diff
...
real 0m12.364s
user 0m11.879s
sys 0m0.262s
Change-Id: Ia458909a300c8555a84f3d7f1f8a410c0856e444
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M Makefile.am
M automation/check-patch.sh
M tox.ini
3 files changed, 23 insertions(+), 12 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/69450
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia458909a300c8555a84f3d7f1f8a410c0856e444
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>