Change in vdsm[master]: Don't report 'imageID' for non-vdsm images in _getDiskStats(...

Mark Wu has uploaded a new change for review.

Change subject: Don't report 'imageID' for non-vdsm images in _getDiskStats()
......................................................................

Don't report 'imageID' for non-vdsm images in _getDiskStats()

Non-vdsm images don't have the attribute 'imageID'. It causes that
_getDiskStats doesn't work for them. So change to only report
'imageID' for vdsm images.

Change-Id: I2a017ba80cd94ee098c7cd7a30095740870c3825
Signed-off-by: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
---
M vdsm/libvirtvm.py
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/6055/1
--
To view, visit http://gerrit.ovirt.org/6055
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a017ba80cd94ee098c7cd7a30095740870c3825
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;

Mark Wu has abandoned this change.

Change subject: Don't report 'imageID' for non-vdsm images in _getDiskStats()
......................................................................


Patch Set 1: Abandoned

This problem will be fixed in
http://gerrit.ovirt.org/#/c/7698/2

Dan has already reviewed that one. So abandon it.

--
To view, visit http://gerrit.ovirt.org/6055
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I2a017ba80cd94ee098c7cd7a30095740870c3825
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Royce Lv has posted comments on this change.

Change subject: Don't report 'imageID' for non-vdsm images in _getDiskStats()
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

Is this what you're referring with the 'alias' error?

--
To view, visit http://gerrit.ovirt.org/6055
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a017ba80cd94ee098c7cd7a30095740870c3825
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Don't report 'imageID' for non-vdsm images in _getDiskStats()
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/6055
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a017ba80cd94ee098c7cd7a30095740870c3825
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Don't report 'imageID' for non-vdsm images in _getDiskStats()
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/190/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/6055
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a017ba80cd94ee098c7cd7a30095740870c3825
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Don't report 'imageID' for non-vdsm images in _getDiskStats()
......................................................................


Patch Set 1: No score

Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/190/

--
To view, visit http://gerrit.ovirt.org/6055
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a017ba80cd94ee098c7cd7a30095740870c3825
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Don't report 'imageID' for non-vdsm images in _getDiskStats()
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/6055
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a017ba80cd94ee098c7cd7a30095740870c3825
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;