4:15 p.m.
Dan Kenigsberg has uploaded a new change for review.
Change subject: vm: drop unused MigrationSourceThreadClass abstraction
......................................................................
vm: drop unused MigrationSourceThreadClass abstraction
Since the libvirtvm.py merger into vm.py (commit ee082b87), we have only
one MigrationSourceThreadClass. Thus, there is no need for this
abstraction.
Change-Id: Ia9fac9aa5b66b68c7447df0c460d91f5f4415b73
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/vm.py
1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/21560/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 4e3650d..703af13 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -1719,7 +1719,6 @@
log = logging.getLogger("vm.Vm")
# limit threads number until the libvirt lock will be fixed
_ongoingCreations = threading.BoundedSemaphore(4)
- MigrationSourceThreadClass = MigrationSourceThread
DeviceMapping = ((DISK_DEVICES, Drive),
(NIC_DEVICES, NetworkInterfaceDevice),
(SOUND_DEVICES, SoundDevice),
@@ -1767,7 +1766,7 @@
self._lastStatus = 'Restoring state'
else:
self._lastStatus = 'WaitForLaunch'
- self._migrationSourceThread = self.MigrationSourceThreadClass(self)
+ self._migrationSourceThread = MigrationSourceThread(self)
self._kvmEnable = self.conf.get('kvmEnable', 'true')
self._guestSocketFile = constants.P_VDSM_RUN + self.conf['vmId'] + \
'.guest.socket'
@@ -2747,8 +2746,7 @@
# taken self Down
if self._lastStatus == 'Down':
return errCode['noVM']
- self._migrationSourceThread = \
- self.MigrationSourceThreadClass(self, **params)
+ self._migrationSourceThread = MigrationSourceThread(self, **params)
self._migrationSourceThread.start()
self._migrationSourceThread.getStat()
return self._migrationSourceThread.status
--
To view, visit http://gerrit.ovirt.org/21560
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9fac9aa5b66b68c7447df0c460d91f5f4415b73
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6:37 p.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: drop unused MigrationSourceThreadClass abstraction
......................................................................
vm: drop unused MigrationSourceThreadClass abstraction
Since the libvirtvm.py merger into vm.py (commit ee082b87), we have only
one MigrationSourceThreadClass. Thus, there is no need for this
abstraction.
Change-Id: Ia9fac9aa5b66b68c7447df0c460d91f5f4415b73
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21560
Reviewed-by: Antoni Segura Puimedon <asegurap(a)redhat.com>
Reviewed-by: Martin Polednik <mpoledni(a)redhat.com>
Reviewed-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M vdsm/vm.py
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Antoni Segura Puimedon: Looks good to me, but someone else must approve
Vinzenz Feenstra: Looks good to me, but someone else must approve
Dan Kenigsberg: Verified; Looks good to me, approved
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/21560
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9fac9aa5b66b68c7447df0c460d91f5f4415b73
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:36 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: vm: drop unused MigrationSourceThreadClass abstraction
......................................................................
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21560
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9fac9aa5b66b68c7447df0c460d91f5f4415b73
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:21 p.m.
Antoni Segura Puimedon has posted comments on this change.
Change subject: vm: drop unused MigrationSourceThreadClass abstraction
......................................................................
Patch Set 1: Code-Review+1
Getting rid of cruft makes me happy!
--
To view, visit http://gerrit.ovirt.org/21560
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9fac9aa5b66b68c7447df0c460d91f5f4415b73
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:23 a.m.
Vinzenz Feenstra has posted comments on this change.
Change subject: vm: drop unused MigrationSourceThreadClass abstraction
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21560
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9fac9aa5b66b68c7447df0c460d91f5f4415b73
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:19 p.m.
Martin Polednik has posted comments on this change.
Change subject: vm: drop unused MigrationSourceThreadClass abstraction
......................................................................
Patch Set 1: Code-Review+1
exactly what Tony said
--
To view, visit http://gerrit.ovirt.org/21560
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9fac9aa5b66b68c7447df0c460d91f5f4415b73
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:18 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: drop unused MigrationSourceThreadClass abstraction
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4845/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5645/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5729/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/21560
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9fac9aa5b66b68c7447df0c460d91f5f4415b73
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3862
days inactive
3869
days old
vdsm-patches@lists.fedorahosted.org
6 comments
5 participants
participants (5)
-
asegurap＠redhat.com -
Dan Kenigsberg -
Jenkins CI RO -
mpoledni＠redhat.com -
Vinzenz Feenstra