Change in vdsm[master]: Revert "Enable metrics by default"

[Code Review]

From Yaniv Bronhaim <ybronhei(a)redhat.com&gt;:

Yaniv Bronhaim has uploaded a new change for review.

Change subject: Revert "Enable metrics by default"
......................................................................

Revert "Enable metrics by default"

This reverts commit b892ccece0e3c4b050b4bee80f4705978a80fa82.

This requires python-statsd first as part of vdsm requirements.

Change-Id: I1a38af2b91688903158df45036da44e3f001307a
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
---
M lib/vdsm/config.py.in
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/66256/1

diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index d606da2..47184ab 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -452,8 +452,8 @@
 
     # Section: [metrics]
     ('metrics', [
-        ('enabled', 'true',
-            'Enable metrics collection (default true)'),
+        ('enabled', 'false',
+            'Enable metrics collection (default false)'),
 
         ('collector_address', 'localhost',
             'Metrics collector address (default localhost)'),


-- 
To view, visit https://gerrit.ovirt.org/66256
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a38af2b91688903158df45036da44e3f001307a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;

[Code Review]

From Yaniv Bronhaim <ybronhei(a)redhat.com&gt;:

Yaniv Bronhaim has posted comments on this change.

Change subject: Revert "Enable metrics by default"
......................................................................


Patch Set 1: Verified+1

please take the revert. I want to verify few more things before merging it. sorry for the
+1 verified before being sure.. I didn't think you'll be so quick

-- 
To view, visit https://gerrit.ovirt.org/66256
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a38af2b91688903158df45036da44e3f001307a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No