Hello Douglas Schilling Landgraf, Dan Kenigsberg,
I'd like you to do a code review. Please visit
to review the following change.
Change subject: nit: remove duplicate command ......................................................................
nit: remove duplicate command
Change-Id: I29eda5849f37f9844df6d648c38a5b8049dd1b9a Signed-off-by: Sandro Bonazzola sbonazzo@redhat.com Reviewed-on: http://gerrit.ovirt.org/26540 Reviewed-by: Dan Kenigsberg danken@redhat.com Reviewed-by: Douglas Schilling Landgraf dougsland@redhat.com --- M debian/vdsm.postinst 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/26704/1
diff --git a/debian/vdsm.postinst b/debian/vdsm.postinst index 67c9794..bc10dc6 100644 --- a/debian/vdsm.postinst +++ b/debian/vdsm.postinst @@ -35,7 +35,6 @@ # -s /bin/false -c "sanlock service" "$SNLK_USER" usermod -a -G "$QEMU_GROUP","$SNLK_GROUP","$LIBVIRT_SOCK_GROUP" "$VDSM_USER" usermod -a -G "$QEMU_GROUP","$VDSM_GROUP" "$SNLK_USER" - usermod -a -G "$QEMU_GROUP","$VDSM_GROUP" "$SNLK_USER"
start_conf_section="## beginning of configuration section by vdsm" end_conf_section="## end of configuration section by vdsm"
Sandro Bonazzola has posted comments on this change.
Change subject: nit: remove duplicate command ......................................................................
Patch Set 1: Verified+1
Dan Kenigsberg has posted comments on this change.
Change subject: nit: remove duplicate command ......................................................................
Patch Set 1:
No need for bz here. Better keep as master.
Dan Kenigsberg has posted comments on this change.
Change subject: nit: remove duplicate command ......................................................................
Patch Set 1: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: nit: remove duplicate command ......................................................................
nit: remove duplicate command
Change-Id: I29eda5849f37f9844df6d648c38a5b8049dd1b9a Signed-off-by: Sandro Bonazzola sbonazzo@redhat.com Reviewed-on: http://gerrit.ovirt.org/26540 Reviewed-by: Dan Kenigsberg danken@redhat.com Reviewed-by: Douglas Schilling Landgraf dougsland@redhat.com Reviewed-on: http://gerrit.ovirt.org/26704 --- M debian/vdsm.postinst 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: Sandro Bonazzola: Verified Dan Kenigsberg: Looks good to me, approved
vdsm-patches@lists.fedorahosted.org