Nir Soffer has uploaded a new change for review.
Change subject: rsourceFactories: Use new resourceManager module api ......................................................................
rsourceFactories: Use new resourceManager module api
Replace usage of getInstance with direct module access.
Change-Id: Icdb30f34257f31622a87d1f496b3f516803eeda8 Signed-off-by: Nir Soffer nsoffer@redhat.com --- M vdsm/storage/resourceFactories.py 1 file changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/65036/1
diff --git a/vdsm/storage/resourceFactories.py b/vdsm/storage/resourceFactories.py index bf8e498..4126db8 100644 --- a/vdsm/storage/resourceFactories.py +++ b/vdsm/storage/resourceFactories.py @@ -31,8 +31,6 @@ import sd import image
-rmanager = rm.ResourceManager.getInstance() - log = logging.getLogger('storage.ResourcesFactories')
@@ -152,12 +150,12 @@ try: if template: if len(volUUIDChain) > 0: - volRes = rmanager.acquireResource( + volRes = rm.acquireResource( self.volumeResourcesNamespace, template, rm.SHARED, timeout=self.resource_default_timeout) else: - volRes = rmanager.acquireResource( + volRes = rm.acquireResource( self.volumeResourcesNamespace, template, lockType, timeout=self.resource_default_timeout) @@ -165,7 +163,7 @@
# Acquire 'lockType' volume locks for volUUID in volUUIDChain: - volRes = rmanager.acquireResource( + volRes = rm.acquireResource( self.volumeResourcesNamespace, volUUID, lockType, timeout=self.resource_default_timeout)
gerrit-hooks has posted comments on this change.
Change subject: rsourceFactories: Use new resourceManager module api ......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: rsourceFactories: Use new resourceManager module api ......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Nir Soffer has posted comments on this change.
Change subject: rsourceFactories: Use new resourceManager module api ......................................................................
Patch Set 2: Verified+1
gerrit-hooks has posted comments on this change.
Change subject: rsourceFactories: Use new resourceManager module api ......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: rsourceFactories: Use new resourceManager module api ......................................................................
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Adam Litke has posted comments on this change.
Change subject: rsourceFactories: Use new resourceManager module api ......................................................................
Patch Set 4: Code-Review+2
Nir Soffer has posted comments on this change.
Change subject: rsourceFactories: Use new resourceManager module api ......................................................................
Patch Set 4: Continuous-Integration+1
Copied from previous version, no code change.
Nir Soffer has submitted this change and it was merged.
Change subject: rsourceFactories: Use new resourceManager module api ......................................................................
rsourceFactories: Use new resourceManager module api
Replace usage of getInstance with direct module access.
Change-Id: Icdb30f34257f31622a87d1f496b3f516803eeda8 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/65036 Reviewed-by: Adam Litke alitke@redhat.com --- M vdsm/storage/resourceFactories.py 1 file changed, 3 insertions(+), 5 deletions(-)
Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified; Passed CI tests
gerrit-hooks has posted comments on this change.
Change subject: rsourceFactories: Use new resourceManager module api ......................................................................
Patch Set 5:
* update_tracker: OK * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org