6:21 a.m.
Hello Bala.FA, Aravinda VK, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21538
to review the following change.
Change subject: gluster: correct parameter for creating hookpath in verb hookAdd.
......................................................................
gluster: correct parameter for creating hookpath in verb hookAdd.
parameter hookLevel must be in lower case for creating correct
path for hook. so that parameter is changed to lower case.
Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60
https://bugzilla.redhat.com/show_bug.cgi?id=1028972
Signed-off-by: ndarshan <dnarayan(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21017
Reviewed-by: Aravinda VK <avishwan(a)redhat.com>
Reviewed-by: Bala.FA <barumuga(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/gluster/hooks.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/21538/1
diff --git a/vdsm/gluster/hooks.py b/vdsm/gluster/hooks.py
index 914d09d..4f1c14d 100644
--- a/vdsm/gluster/hooks.py
+++ b/vdsm/gluster/hooks.py
@@ -244,7 +244,7 @@
@makePublic
def hookAdd(glusterCmd, hookLevel, hookName, hookData, hookMd5Sum,
enable=False):
- hookPath = os.path.join(_glusterHooksPath, glusterCmd, hookLevel)
+ hookPath = os.path.join(_glusterHooksPath, glusterCmd, hookLevel.lower())
try:
os.makedirs(hookPath)
if selinux.is_selinux_enabled():
--
To view, visit http://gerrit.ovirt.org/21538
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
3:21 a.m.
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: gluster: correct parameter for creating hookpath in verb hookAdd.
......................................................................
gluster: correct parameter for creating hookpath in verb hookAdd.
parameter hookLevel must be in lower case for creating correct
path for hook. so that parameter is changed to lower case.
Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1028972
Signed-off-by: ndarshan <dnarayan(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21017
Reviewed-by: Aravinda VK <avishwan(a)redhat.com>
Reviewed-by: Bala.FA <barumuga(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21538
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Tested-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M vdsm/gluster/hooks.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yaniv Bronhaim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21538
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
3:21 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: gluster: correct parameter for creating hookpath in verb hookAdd.
......................................................................
Patch Set 5: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21538
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
2:27 a.m.
Bala.FA has posted comments on this change.
Change subject: gluster: correct parameter for creating hookpath in verb hookAdd.
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21538
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
4:13 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: gluster: correct parameter for creating hookpath in verb hookAdd.
......................................................................
Patch Set 2: Code-Review+1
verified? please take care of rhev-3.3 ack on BZ 1028972 asap. thanks
--
To view, visit http://gerrit.ovirt.org/21538
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
9:55 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: correct parameter for creating hookpath in verb hookAdd.
......................................................................
Patch Set 1: Code-Review-1
Commit message should have Bug-Url (not as you have spelled on the master branch). Other
than that, ack for ovirt-3.3.
--
To view, visit http://gerrit.ovirt.org/21538
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-HasComments: No
11:46 p.m.
Bala.FA has posted comments on this change.
Change subject: gluster: correct parameter for creating hookpath in verb hookAdd.
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
....................................................
Commit Message
Line 9: parameter hookLevel must be in lower case for creating correct
Line 10: path for hook. so that parameter is changed to lower case.
Line 11:
Line 12: Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60
Line 13: https://bugzilla.redhat.com/show_bug.cgi?id=1028972
Prefix with Bug-Url:
Line 14: Signed-off-by: ndarshan <dnarayan(a)redhat.com>
Line 15: Reviewed-on: http://gerrit.ovirt.org/21017
Line 16: Reviewed-by: Aravinda VK <avishwan(a)redhat.com>
Line 17: Reviewed-by: Bala.FA <barumuga(a)redhat.com>
--
To view, visit http://gerrit.ovirt.org/21538
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-HasComments: Yes
2:28 a.m.
Bala.FA has posted comments on this change.
Change subject: gluster: correct parameter for creating hookpath in verb hookAdd.
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/21538
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
12:33 a.m.
Darshan N has posted comments on this change.
Change subject: gluster: correct parameter for creating hookpath in verb hookAdd.
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21538
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
3:48 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: correct parameter for creating hookpath in verb hookAdd.
......................................................................
Patch Set 2: Code-Review+2
Thanks!
--
To view, visit http://gerrit.ovirt.org/21538
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
9:30 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: correct parameter for creating hookpath in verb hookAdd.
......................................................................
Patch Set 4: Code-Review+2
same as master
--
To view, visit http://gerrit.ovirt.org/21538
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
3803
days inactive
3819
days old
vdsm-patches@lists.fedorahosted.org
10 comments
4 participants
participants (4)
-
barumuga＠redhat.com -
Dan Kenigsberg -
dnarayan＠redhat.com -
ybronhei＠redhat.com