Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
......................................................................
Patch Set 13:
From the discussion with Richard and Kevin, we learned that we can use this only on the top volume in an image. We need to validate that the volume requested by the caller is the leaf volume, and fail the request if not.
We also must prevent usage of this verb on a template image used by any other image. Doing this check safely may be hard since it can be done only on the spm.
Finally we must protect the image during the operation using volume generation and mark the image as illegal, so another host cannot consume this image while we are sparsifying it. See the latest version of copy_data for the details how it is done.
--
To view, visit
https://gerrit.ovirt.org/57347
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud
smelamud@redhat.com
Gerrit-Reviewer: Adam Litke
alitke@redhat.com
Gerrit-Reviewer: Allon Mureinik
amureini@redhat.com
Gerrit-Reviewer: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk
mlipchuk@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: Shahar Havivi
shavivi@redhat.com
Gerrit-Reviewer: Shmuel Leib Melamud
smelamud@redhat.com
Gerrit-Reviewer: Shmuel Melamud
smelamud@redhat.com
Gerrit-Reviewer: Yaniv Kaul
ykaul@redhat.com
Gerrit-Reviewer: gerrit-hooks
automation@ovirt.org
Gerrit-HasComments: No