Dan Kenigsberg has uploaded a new change for review.
Change subject: Specify which user/group should be used for core dumps rotation ......................................................................
Specify which user/group should be used for core dumps rotation
New 'su' directive is new to logrotate 3.8.0. This patch breaks systems with older logrotate.
Change-Id: I38738f494e9bd241ea27e6e18b4d348fc3dfe643 --- M configure.ac M vdsm.spec.in R vdsm/vdsm-logrotate.conf.in 3 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/971/1 -- To view, visit http://gerrit.ovirt.org/971 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I38738f494e9bd241ea27e6e18b4d348fc3dfe643 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: mhuntxu@gmail.com
Federico Simoncelli has posted comments on this change.
Change subject: Specify which user/group should be used for core dumps rotation ......................................................................
Patch Set 1: (2 inline comments)
.................................................... File vdsm.spec.in Line 34: Requires: logrotate >= 3.8.0 If this is different in fedora/rhel, split it in the %if 0%{?rhel}/%else parts.
.................................................... File vdsm/vdsm-logrotate.conf.in Line 19: su @VDSMUSER@ @VDSMGROUP@ Make this as a complete macro eg: @LOGROTATE_SU_CONFIG@ which is empty on rhel (you should detect that on configure, probably checking the logrotate version).
-- To view, visit http://gerrit.ovirt.org/971 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I38738f494e9bd241ea27e6e18b4d348fc3dfe643 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: mhuntxu@gmail.com
Dan Kenigsberg has posted comments on this change.
Change subject: Specify which user/group should be used for core dumps rotation ......................................................................
Patch Set 1:
should mention bug 772591
-- To view, visit http://gerrit.ovirt.org/971 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I38738f494e9bd241ea27e6e18b4d348fc3dfe643 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: mhuntxu@gmail.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#772591 Specify which user/group should be used for core dumps rotation ......................................................................
Patch Set 2: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/971 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I38738f494e9bd241ea27e6e18b4d348fc3dfe643 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: mhuntxu@gmail.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#772591 Specify which user/group should be used for core dumps rotation ......................................................................
BZ#772591 Specify which user/group should be used for core dumps rotation
New 'su' directive is new to logrotate 3.8.0. This patch breaks systems with older logrotate.
Change-Id: I38738f494e9bd241ea27e6e18b4d348fc3dfe643 --- M configure.ac M vdsm.spec.in R vdsm/vdsm-logrotate.conf.in 3 files changed, 3 insertions(+), 1 deletion(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/971 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I38738f494e9bd241ea27e6e18b4d348fc3dfe643 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: mhuntxu@gmail.com
vdsm-patches@lists.fedorahosted.org