Change in vdsm[master]: Make svdsm files depend on path definitions

Shu Ming has uploaded a new change for review.

Change subject: Make svdsm files depend on path definitions
......................................................................

Make svdsm files depend on path definitions

The files created by super vdsm process should
be put into path defined by the path definition
in constants.py

Change-Id: Ia952e930d719c65a9bc503f8a097bdfc26b5a397
Signed-off-by: Shu Ming 
---
M vdsm/supervdsm.py
1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/7540/1

diff --git a/vdsm/supervdsm.py b/vdsm/supervdsm.py
index 3e881e8..7031a79 100644
--- a/vdsm/supervdsm.py
+++ b/vdsm/supervdsm.py
@@ -45,8 +45,9 @@

raise RuntimeError("SuperVDSM Server not found")

-PIDFILE = "/var/run/vdsm/svdsm.pid"
-ADDRESS = "/var/run/vdsm/svdsm.sock"
+VAR_RUN_VDSM = constants.P_VDSM_RUN
+PIDFILE = os.path.join(VAR_RUN_VDSM, "svdsm.pid")
+ADDRESS = os.path.join(VAR_RUN_VDSM, "svdm.sock")
 SUPERVDSM = __supervdsmServerPath()

--
To view, visit http://gerrit.ovirt.org/7540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia952e930d719c65a9bc503f8a097bdfc26b5a397
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Make svdsm files depend on path definitions
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/728/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/7540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia952e930d719c65a9bc503f8a097bdfc26b5a397
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Make svdsm files depend on path definitions
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/supervdsm.py
Line 45: 
Line 46:     raise RuntimeError("SuperVDSM Server not found")
Line 47: 
Line 48: VAR_RUN_VDSM = constants.P_VDSM_RUN
Line 49: PIDFILE = os.path.join(VAR_RUN_VDSM, "svdsm.pid")
I'd find it clearer to simply use constants.P_VDSM_RUN on both cases.
Line 50: ADDRESS = os.path.join(VAR_RUN_VDSM, "svdsm.sock")
Line 51: SUPERVDSM = __supervdsmServerPath()
Line 52: 
Line 53:

--
To view, visit http://gerrit.ovirt.org/7540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia952e930d719c65a9bc503f8a097bdfc26b5a397
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: oVirt Jenkins CI Server

Yaniv Bronhaim has posted comments on this change.

Change subject: Make svdsm files depend on path definitions
......................................................................

Patch Set 2: Verified; I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/supervdsm.py
Line 45: 
Line 46:     raise RuntimeError("SuperVDSM Server not found")
Line 47: 
Line 48: VAR_RUN_VDSM = constants.P_VDSM_RUN
Line 49: PIDFILE = os.path.join(VAR_RUN_VDSM, "svdsm.pid")
I agree.
Line 50: ADDRESS = os.path.join(VAR_RUN_VDSM, "svdsm.sock")
Line 51: SUPERVDSM = __supervdsmServerPath()
Line 52: 
Line 53:

--
To view, visit http://gerrit.ovirt.org/7540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia952e930d719c65a9bc503f8a097bdfc26b5a397
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server

Yaniv Bronhaim has posted comments on this change.

Change subject: Make svdsm files depend on path definitions
......................................................................

Patch Set 3: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia952e930d719c65a9bc503f8a097bdfc26b5a397
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Make svdsm files depend on path definitions
......................................................................

Patch Set 3: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/7540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia952e930d719c65a9bc503f8a097bdfc26b5a397
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Make svdsm files depend on path definitions
......................................................................

Make svdsm files depend on path definitions

The files created by super vdsm process should
be put into a path relative to the path definition
in constants.py

Change-Id: Ia952e930d719c65a9bc503f8a097bdfc26b5a397
Signed-off-by: Shu Ming 
---
M vdsm/supervdsm.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Yaniv Bronhaim: Verified; Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/7540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia952e930d719c65a9bc503f8a097bdfc26b5a397
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server