Change in vdsm[master]: Related to BZ#844347 - Keep bond mode after change network o...

[Igor Lvovsky]

Igor Lvovsky has uploaded a new change for review.

Change subject: Related to BZ#844347 - Keep bond mode after change network on top of it
......................................................................

Related to BZ#844347 - Keep bond mode after change network on top of it

Assume we have a bond with mode X and network on it. Now we want to remove this network
and add another one.
In this case setupNetwork will get a new network but not a bond info.
We need to take bond info from the host and keep it during network addition

Change-Id: Idac51ecbef9d11f31e9bd962d3aefbde34e3fb54
Signed-off-by: Igor Lvovsky 
---
M vdsm/configNetwork.py
1 file changed, 12 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/6805/1
--
To view, visit http://gerrit.ovirt.org/6805
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idac51ecbef9d11f31e9bd962d3aefbde34e3fb54
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Related to BZ#844347 - Keep bond mode after change network on top of it
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/6805
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idac51ecbef9d11f31e9bd962d3aefbde34e3fb54
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer

Antoni Segura Puimedon has posted comments on this change.

Change subject: Related to BZ#844347 - Keep bond mode after change network on top of it
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 1197:             # We need to use a newest host info
Grammar: "a newer" or "the newest", although I recommend the first option.

--
To view, visit http://gerrit.ovirt.org/6805
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idac51ecbef9d11f31e9bd962d3aefbde34e3fb54
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Related to BZ#844347 - Keep bond mode after change network on top of it
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

good by me, minor comments though.

....................................................
File vdsm/configNetwork.py
Line 1214:                         logger.debug("Updating bond %r info" % d['bonding'])
use , instead of  %

or delete completely.

--
To view, visit http://gerrit.ovirt.org/6805
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idac51ecbef9d11f31e9bd962d3aefbde34e3fb54
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Related to BZ#844347 - Keep bond mode after change network on top of it
......................................................................

Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/6805
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idac51ecbef9d11f31e9bd962d3aefbde34e3fb54
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Related to BZ#844347 - Keep bond mode after change network on top of it
......................................................................

Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/6805
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idac51ecbef9d11f31e9bd962d3aefbde34e3fb54
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Related to BZ#844347 - Keep bond mode after change network on top of it
......................................................................

Related to BZ#844347 - Keep bond mode after change network on top of it

Assume we have a bond with mode X and network on it. Now we want to remove this network
and add another one.
In this case setupNetwork will get a new network but not a bond info.
We need to take bond info from the host and keep it during network addition

Change-Id: Idac51ecbef9d11f31e9bd962d3aefbde34e3fb54
Signed-off-by: Igor Lvovsky 
---
M vdsm/configNetwork.py
1 file changed, 12 insertions(+), 2 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Igor Lvovsky: Verified

--
To view, visit http://gerrit.ovirt.org/6805
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idac51ecbef9d11f31e9bd962d3aefbde34e3fb54
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer