Change in vdsm[master]: hooks: vm: graphics console listen on all ifs

Frank Kobzik has uploaded a new change for review.

Change subject: hooks: vm: graphics console listen on all ifs
......................................................................

hooks: vm: graphics console listen on all ifs

This hook makes the graphics console device listen on all interfaces (instead
of listening on display network).

The configuration is described in the hook itself.

Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com&gt;
Change-Id: I512586497209cb631e684c5f09084dcecfca0ec3
---
A vdsm_hooks/console_listen_on_all_ifs/before_vm_start.py
1 file changed, 101 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/35661/1

diff --git a/vdsm_hooks/console_listen_on_all_ifs/before_vm_start.py
b/vdsm_hooks/console_listen_on_all_ifs/before_vm_start.py
new file mode 100755
index 0000000..a26f50e
--- /dev/null
+++ b/vdsm_hooks/console_listen_on_all_ifs/before_vm_start.py
@@ -0,0 +1,101 @@
+#!/usr/bin/python
+
+import os
+import ConfigParser
+import sys
+import hooking
+import traceback
+from xml.dom import minidom
+from vdsm.config import config
+
+#
+# Placed in before_vm_start
+#
+# This hook makes graphics console server listen on all interfaces (instead of
+# on one dedicated display network).
+#
+# Configuration:
+# in /etc/vdsm.conf add this line:
+# console_listen_on_all_ifs = true
+#
+# Example input:
+# <domain>
+# <devices>
+#     <graphics type='spice' port='5900' autoport='yes'
listen='127.0.0.1'>
+#         <listen type='address' address='127.0.0.1'/>
+#     </graphics>
+# </devices>
+# </domain>
+# Corresponding output:
+# <domain>
+# <devices>
+#     <graphics type='spice' port='5900' autoport='yes'
listen='127.0.0.1'>
+#         <listen type='address' address='0'/>
+#     </graphics>
+# </devices>
+# </domain>
+#
+
+
+def wipe_listen_children(elem):
+    listens = elem.getElementsByTagName('listen')
+    for listen in listens:
+        elem.removeChild(listen)
+
+
+def add_promiscuous_listen(elem, doc):
+    listen = doc.createElement('listen')
+    listen.setAttribute('type', 'address')
+    listen.setAttribute('address', '0')
+    elem.appendChild(listen)
+
+
+def adjust_graphics(domxml):
+    for graphics in domxml.getElementsByTagName('graphics'):
+        wipe_listen_children(graphics)
+        add_promiscuous_listen(graphics, domxml)
+
+
+def main():
+    try:
+        if config.getboolean('vars', 'console_listen_on_all_ifs'):
+            sys.stderr.write('console_listen_on_all_ifs: '
+                             'starting to modify vm \n')
+            domxml = hooking.read_domxml()
+            adjust_graphics(domxml)
+            hooking.write_domxml(domxml)
+    except ConfigParser.NoOptionError:
+        sys.stderr.write('console_listen_on_all_ifs: WARN : '
+                         'Couldn\'t read configuration.')
+    except:
+        sys.stderr.write('console_listen_on_all_ifs: ERROR %s\n' %
+                         traceback.format_exc())
+        sys.exit(2)
+
+
+def test():
+    domxml = minidom.parseString("""
+    <domain>
+    <devices>
+    <graphics type='spice' port='5900' autoport='yes'
listen='127.0.0.1'>
+        <listen type='address' address='127.0.0.1'/>
+    </graphics>
+    </devices>
+    </domain>
+    """)
+    print "Domain before applying hook: %s" % \
+        domxml.toxml(encoding='UTF-8')
+    adjust_graphics(domxml)
+    print "Graphics console after applying hook: %s" % \
+        domxml.toxml(encoding='UTF-8')
+
+
+if __name__ == '__main__':
+    try:
+        if '--test' in sys.argv:
+            test()
+        else:
+            main()
+    except:
+        hooking.exit_hook('extnet hook: [unexpected error]: %s\n' %
+                          traceback.format_exc())


-- 
To view, visit http://gerrit.ovirt.org/35661
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I512586497209cb631e684c5f09084dcecfca0ec3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com&gt;

Frank Kobzik has posted comments on this change.

Change subject: hooks: vm: graphics console listen on all ifs
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/35661
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I512586497209cb631e684c5f09084dcecfca0ec3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com&gt;
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: hooks: vm: graphics console listen on all ifs
......................................................................


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13729/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12940/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13892/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/35661
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I512586497209cb631e684c5f09084dcecfca0ec3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: vm: graphics console listen on all ifs
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/35661/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: hooks: vm: graphics console listen on all ifs
Line 8: 
Line 9: This hook makes the graphics console device listen on all interfaces (instead
Line 10: of listening on display network).
why is it good? who should use this hook? does this use case work with
http://www.ovirt.org/Features/Multiple_Gateways ?

the name is too long and not clear enough.how about no_display_net?

You must update the spec and makefile. See http://gerrit.ovirt.org/22124 for an example.
Line 11: 
Line 12: The configuration is described in the hook itself.
Line 13: 
Line 14: Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com&gt;


http://gerrit.ovirt.org/#/c/35661/1/vdsm_hooks/console_listen_on_all_ifs/...
File vdsm_hooks/console_listen_on_all_ifs/before_vm_start.py:

Line 57: 
Line 58: 
Line 59: def main():
Line 60:     try:
Line 61:         if config.getboolean('vars',
'console_listen_on_all_ifs'):
using vdsm.conf to control this hook is not a good idea, as it requires further setting on
each host, and apply to all VMs.

Per-VM custom property are a fine control lever.
Line 62:             sys.stderr.write('console_listen_on_all_ifs: '
Line 63:                              'starting to modify vm \n')
Line 64:             domxml = hooking.read_domxml()
Line 65:             adjust_graphics(domxml)


-- 
To view, visit http://gerrit.ovirt.org/35661
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I512586497209cb631e684c5f09084dcecfca0ec3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: vm: graphics console listen on all ifs
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/35661/1/vdsm_hooks/console_listen_on_all_ifs/...
File vdsm_hooks/console_listen_on_all_ifs/before_vm_start.py:

Line 82:     </graphics>
Line 83:     </devices>
Line 84:     </domain>
Line 85:     """)
Line 86:     print "Domain before applying hook: %s" % \
oh, and please use sys.stdout.write(), or function-like print().
Line 87:         domxml.toxml(encoding='UTF-8')
Line 88:     adjust_graphics(domxml)
Line 89:     print "Graphics console after applying hook: %s" % \
Line 90:         domxml.toxml(encoding='UTF-8')


-- 
To view, visit http://gerrit.ovirt.org/35661
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I512586497209cb631e684c5f09084dcecfca0ec3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: hooks: vm: graphics console listen on all ifs
......................................................................


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13753/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12964/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13916/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/35661
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I512586497209cb631e684c5f09084dcecfca0ec3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Frank Kobzik has abandoned this change.

Change subject: hooks: vm: graphics console listen on all ifs
......................................................................


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/35661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I512586497209cb631e684c5f09084dcecfca0ec3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt(a)midokura.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server

automation(a)ovirt.org has posted comments on this change.

Change subject: hooks: vm: graphics console listen on all ifs
......................................................................


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/35661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I512586497209cb631e684c5f09084dcecfca0ec3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt(a)midokura.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No