7:09 a.m.
Yaniv Bronhaim has uploaded a new change for review.
Change subject: changed upstart_libvirt function name
......................................................................
changed upstart_libvirt function name
Change-Id: I7b773b04766346ab93333b00fba6a1f083cffd89
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M vdsm/vdsmd.init.in
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/7671/1
diff --git a/vdsm/vdsmd.init.in b/vdsm/vdsmd.init.in
index 4a66136..397d888 100755
--- a/vdsm/vdsmd.init.in
+++ b/vdsm/vdsmd.init.in
@@ -147,7 +147,7 @@
return 0
}
-upstart_libvirt() {
+libvirt_should_use_upstart() {
[[ -x /sbin/initctl ]]
}
@@ -414,7 +414,7 @@
stop_libvirtd_sysv() {
# stop libvirt SysV service if we intend to configure upstart
- if upstart_libvirt && ! [[ -f /etc/init/libvirtd.conf ]]; then
+ if libvirt_should_use_upstart && ! [[ -f /etc/init/libvirtd.conf ]]; then
/sbin/chkconfig libvirtd off
/sbin/service libvirtd stop
fi
@@ -442,7 +442,7 @@
local packaged target
local startout
- if ! upstart_libvirt; then
+ if ! libvirt_should_use_upstart; then
/sbin/service libvirtd start
return
fi
--
To view, visit http://gerrit.ovirt.org/7671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b773b04766346ab93333b00fba6a1f083cffd89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
12:32 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: changed upstart_libvirt function name
......................................................................
changed upstart_libvirt function name
Change-Id: I7b773b04766346ab93333b00fba6a1f083cffd89
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M vdsm/vdsmd.init.in
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, but someone else must approve
Yaniv Bronhaim: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b773b04766346ab93333b00fba6a1f083cffd89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12:32 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: changed upstart_libvirt function name
......................................................................
Patch Set 1: Looks good to me, approved
valid renaming
--
To view, visit http://gerrit.ovirt.org/7671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b773b04766346ab93333b00fba6a1f083cffd89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:06 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: changed upstart_libvirt function name
......................................................................
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b773b04766346ab93333b00fba6a1f083cffd89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:06 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: changed upstart_libvirt function name
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b773b04766346ab93333b00fba6a1f083cffd89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:18 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: changed upstart_libvirt function name
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/807/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/7671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b773b04766346ab93333b00fba6a1f083cffd89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4108
days inactive
4111
days old
vdsm-patches@lists.fedorahosted.org
5 comments
4 participants
participants (4)
-
Dan Kenigsberg -
Douglas Schilling Landgraf -
Jenkins CI RO -
ybronhei＠redhat.com