10:15 a.m.
New patch submitted by Igor Lvovsky (ilvovsky(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/709
commit bb1cba217e45a05dedcdc689611842b4b64be607
Author: Igor Lvovsky <ilvovsky(a)redhat.com>
Date: Thu Jul 14 15:14:47 2011 +0300
Related to BZ#719255 - Release lock if prepare volume failed
Change-Id: I0eeeda07037824bb822b8d0d1fff869959bdfefc
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index b0d5d21..ccf93d5 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -1671,8 +1671,8 @@ class HSM:
vol.refreshVolume()
vol.prepare(rw=rw)
except:
- imgResource.autoRelease = True
self.log.error("Prepare volume %s in domain %s failed", volUUID,
sdUUID, exc_info=True)
+ rmanager.releaseResource(imageResourcesNamespace, imgUUID)
raise
6:12 a.m.
New subject: Change in vdsm[master]: Related to BZ#719255 - Release lock if prepare volume failed
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Related to BZ#719255 - Release lock if prepare volume failed
......................................................................
Related to BZ#719255 - Release lock if prepare volume failed
We need release lock explicitly and not with autoRelease mechanism.
This mechanism wouldn't work always. It depends on behaviour of
different Python's components such like garbage collector and so on.
Change-Id: I0eeeda07037824bb822b8d0d1fff869959bdfefc
---
M vdsm/storage/hsm.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Igor Lvovsky: Verified
Saggi Mizrahi: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/709
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0eeeda07037824bb822b8d0d1fff869959bdfefc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
6:12 a.m.
New subject: Change in vdsm[master]: Related to BZ#719255 - Release lock if prepare volume failed
Dan Kenigsberg has posted comments on this change.
Change subject: Related to BZ#719255 - Release lock if prepare volume failed
......................................................................
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/709
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0eeeda07037824bb822b8d0d1fff869959bdfefc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:53 a.m.
New subject: Change in vdsm[master]: Related to BZ#719255 - Release lock if prepare volume failed
Saggi Mizrahi has posted comments on this change.
Change subject: Related to BZ#719255 - Release lock if prepare volume failed
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/709
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0eeeda07037824bb822b8d0d1fff869959bdfefc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
1:50 p.m.
New subject: Change in vdsm[master]: Related to BZ#719255 - Release lock if prepare volume failed
Dan Kenigsberg has posted comments on this change.
Change subject: Related to BZ#719255 - Release lock if prepare volume failed
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/709
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0eeeda07037824bb822b8d0d1fff869959bdfefc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
7:42 a.m.
New subject: Change in vdsm[master]: Related to BZ#719255 - Release lock if prepare volume failed
Igor Lvovsky has posted comments on this change.
Change subject: Related to BZ#719255 - Release lock if prepare volume failed
......................................................................
Patch Set 2: Verified
--
To view, visit http://gerrit.usersys.redhat.com/709
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0eeeda07037824bb822b8d0d1fff869959bdfefc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
7:34 a.m.
New subject: Change in vdsm[master]: Related to BZ#719255 - Release lock if prepare volume failed
Igor Lvovsky has posted comments on this change.
Change subject: Related to BZ#719255 - Release lock if prepare volume failed
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 1675: rmanager.releaseResource(imageResourcesNamespace, imgUUID)
Yes, I know you was right (as usual) :)
The reason is, that autoRelease wouldn't works every time
As I understand now, it's depends on several things in Python like garbageCollection
and so on.
I saw it works and today saw it doesn't work (in Moti's setup).
So, current solution works every time
--
To view, visit http://gerrit.usersys.redhat.com/709
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0eeeda07037824bb822b8d0d1fff869959bdfefc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
7:26 a.m.
New subject: Change in vdsm[master]: Related to BZ#719255 - Release lock if prepare volume failed
Dan Kenigsberg has posted comments on this change.
Change subject: Related to BZ#719255 - Release lock if prepare volume failed
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 1675: rmanager.releaseResource(imageResourcesNamespace, imgUUID)
when I suggested that, you said autoRelease was prettier. Why now? Please explain the
benefits in the commit message.
--
To view, visit http://gerrit.usersys.redhat.com/709
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0eeeda07037824bb822b8d0d1fff869959bdfefc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
7:15 a.m.
New subject: Change in vdsm[master]: Related to BZ#719255 - Release lock if prepare volume failed
Igor Lvovsky has posted comments on this change.
Change subject: Related to BZ#719255 - Release lock if prepare volume failed
......................................................................
Patch Set 1: Verified
--
To view, visit http://gerrit.usersys.redhat.com/709
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0eeeda07037824bb822b8d0d1fff869959bdfefc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4724
days inactive
4727
days old
vdsm-patches@lists.fedorahosted.org
8 comments
3 participants
participants (3)
-
Dan Kenigsberg -
Igor Lvovsky -
smizrahi＠redhat.com