Change in vdsm[master]: Remove Pool.isMember() function.

Eduardo has uploaded a new change for review.

Change subject: Remove Pool.isMember() function.
......................................................................

Remove Pool.isMember() function.

Related to BZ#878894.

Change-Id: I648c22f4914ed3d13994b7c5049fc6083f02633f
Signed-off-by: Eduardo 
---
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
2 files changed, 3 insertions(+), 8 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/9454/1

diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 358876d..e47eee1 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -269,8 +269,10 @@

@classmethod
     def validatePoolSD(cls, spUUID, sdUUID):
-        if not cls.getPool(spUUID).isMember(sdUUID):
+        pool = cls.getPool(spUUID)
+        if sdUUID not in pool.getDomains():
             raise se.StorageDomainNotMemberOfPool(spUUID, sdUUID)
+        return pool

@classmethod
     def validateNonDomain(cls, sdUUID):
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index ac5e1db..25134d5 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -1618,13 +1618,6 @@
         return domainslist

@unsecured
-    def isMember(self, sdUUID, checkActive=False):
-        """
-        Check if domain is member in the pool.
-        """
-        return sdUUID in self.getDomains(activeOnly=checkActive)
-
-    @unsecured
     def isActive(self, sdUUID):
         return sdUUID in self.getDomains(activeOnly=True)

--
To view, visit http://gerrit.ovirt.org/9454
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I648c22f4914ed3d13994b7c5049fc6083f02633f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Remove Pool.isMember() function.
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/135/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9454
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I648c22f4914ed3d13994b7c5049fc6083f02633f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Remove Pool.isMember() function.
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/169/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9454
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I648c22f4914ed3d13994b7c5049fc6083f02633f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Remove Pool.isMember() function.
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/135/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/169/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9454
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I648c22f4914ed3d13994b7c5049fc6083f02633f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

Royce Lv has posted comments on this change.

Change subject: Remove Pool.isMember() function.
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/9454
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I648c22f4914ed3d13994b7c5049fc6083f02633f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

Yeela Kaplan has posted comments on this change.

Change subject: Remove Pool.isMember() function.
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/9454
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I648c22f4914ed3d13994b7c5049fc6083f02633f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Remove Pool.isMember() function.
......................................................................

Remove Pool.isMember() function.

Related to BZ#878894.

Change-Id: I648c22f4914ed3d13994b7c5049fc6083f02633f
Signed-off-by: Eduardo 
---
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
2 files changed, 3 insertions(+), 8 deletions(-)

Approvals:
  Royce Lv: Looks good to me, but someone else must approve
  Yeela Kaplan: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/9454
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I648c22f4914ed3d13994b7c5049fc6083f02633f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Remove Pool.isMember() function.
......................................................................

Patch Set 1: Verified; Looks good to me, approved

verified that the dropped method is used nowhere else.

--
To view, visit http://gerrit.ovirt.org/9454
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I648c22f4914ed3d13994b7c5049fc6083f02633f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server