Change in vdsm[master]: vdsm/vdsm: fix vdsm start failure

Zhou Zheng Sheng has uploaded a new change for review.

Change subject: vdsm/vdsm: fix vdsm start failure
......................................................................

vdsm/vdsm: fix vdsm start failure

vdsm checks the log file permissions before start. However the log file
path in the code is not correct, so it checks a non-existing file and
always fails. This patch fix the problem.

Change-Id: I102c017e564f0f24782992fae29395ae556b34ed
Signed-off-by: Zhou Zheng Sheng 
---
M vdsm/vdsm
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/10145/1

diff --git a/vdsm/vdsm b/vdsm/vdsm
index 5e07b56..ec291b7 100755
--- a/vdsm/vdsm
+++ b/vdsm/vdsm
@@ -113,7 +113,7 @@

def __assertLogPermission():
-    logfile = constants.P_VDSM_LOG + "vdsm.log"
+    logfile = constants.P_VDSM_LOG + "/vdsm.log"
     if not os.access(logfile, os.W_OK):
         syslog.syslog("error in accessing vdsm log file")
         sys.exit(1)

--
To view, visit http://gerrit.ovirt.org/10145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I102c017e564f0f24782992fae29395ae556b34ed
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm/vdsm: fix vdsm start failure
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/369/ (2/2)

--
To view, visit http://gerrit.ovirt.org/10145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I102c017e564f0f24782992fae29395ae556b34ed
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm/vdsm: fix vdsm start failure
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/403/ (1/2)

--
To view, visit http://gerrit.ovirt.org/10145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I102c017e564f0f24782992fae29395ae556b34ed
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm/vdsm: fix vdsm start failure
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/369/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/403/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/10145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I102c017e564f0f24782992fae29395ae556b34ed
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server

Zhou Zheng Sheng has posted comments on this change.

Change subject: vdsm/vdsm: fix vdsm start failure
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/10145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I102c017e564f0f24782992fae29395ae556b34ed
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm/vdsm: fix vdsm start failure
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/10145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I102c017e564f0f24782992fae29395ae556b34ed
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm/vdsm: fix vdsm start failure
......................................................................

Patch Set 1: Looks good to me, approved

Sorry!

--
To view, visit http://gerrit.ovirt.org/10145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I102c017e564f0f24782992fae29395ae556b34ed
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm/vdsm: fix vdsm start failure
......................................................................

vdsm/vdsm: fix vdsm start failure

vdsm checks the log file permissions before start. However the log file
path in the code is not correct, so it checks a non-existing file and
always fails. This patch fix the problem.

Change-Id: I102c017e564f0f24782992fae29395ae556b34ed
Signed-off-by: Zhou Zheng Sheng 
---
M vdsm/vdsm
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Zhou Zheng Sheng: Verified

--
To view, visit http://gerrit.ovirt.org/10145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I102c017e564f0f24782992fae29395ae556b34ed
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: vdsm/vdsm: fix vdsm start failure
......................................................................

Patch Set 2:

I know this is a fix... but using os.path.join would have been better.

--
To view, visit http://gerrit.ovirt.org/10145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I102c017e564f0f24782992fae29395ae556b34ed
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Haim Ateya 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server