Change in vdsm[master]: bz#831938 raise exception when error occurs in connectStorag...

Royce Lv has uploaded a new change for review.

Change subject: bz#831938 raise exception when error occurs in connectStorageServer
......................................................................

bz#831938 raise exception when error occurs in connectStorageServer

connectStorageServer returned OK when error occurs:
iscsi login fails, local directory lack of permission,etc
change it to raise error to make early alarm

Change-Id: I4c363f41d08669eec022797eb1eb440fe193f9c2
Signed-off-by: Royce Lv 
---
M vdsm/storage/hsm.py
1 file changed, 2 insertions(+), 8 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/6137/1
--
To view, visit http://gerrit.ovirt.org/6137
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c363f41d08669eec022797eb1eb440fe193f9c2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv

Itamar Heim has posted comments on this change.

Change subject: bz#831938 raise exception when error occurs in connectStorageServer
......................................................................

Patch Set 1:

still relevant or should be abandoned?

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: bz#831938 raise exception when error occurs in connectStorageServer
......................................................................

Patch Set 1: Code-Review-1

(1 comment)

....................................................
File vdsm/storage/hsm.py
Line 1937:                 self.log.error("Could not connect to storageServer", exc_info=True)
Line 1938:                 raise
Line 1939:         # Connecting new device may change the visible storage domain list
Line 1940:         # so invalidate caches
Line 1941:         sdCache.invalidateStorage()
connectStorageServer receives a list of connections and returns a list of results (e.g. which connections succeeded and which ones failed). At the present time we cannot modify that for backward compatibility. More importantly in the change you're suggesting there's no feedback on what connections succeeded before failing (raise).
Line 1942: 
Line 1943:     @deprecated
Line 1944:     def _connectStorageOverIser(self, conDef, conObj, conTypeId):
Line 1945:         """

Itamar Heim has abandoned this change.

Change subject: bz#831938 raise exception when error occurs in connectStorageServer
......................................................................

Abandoned

no comment for 30 days post last ping. abandoning. please re-open if/when relevant and/or ping reviewers directly / promote discussion about the patch in the mailing list.