From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Introducing validate_bond_names to netswitch validators
......................................................................
net: Introducing validate_bond_names to netswitch validators
There is no difference in the definition of valid bond names
between OVS and legacy switch. As such, bond name validation
was moved upwards to netswitch validators.
Besides checking for valid bond names upon bond creation,
we're now also checking the names of externally created bonds
that networks are being set on.
Change-Id: I02923dd6d1c444b6b6e7678e0b8af0d078202edc
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M lib/vdsm/network/legacy_switch.py
M lib/vdsm/network/models.py
M lib/vdsm/network/netswitch/configurator.py
M lib/vdsm/network/netswitch/validator.py
M tests/network/models_test.py
M tests/network/netswitch_test.py
6 files changed, 54 insertions(+), 21 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
Edward Haas: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/76457
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02923dd6d1c444b6b6e7678e0b8af0d078202edc
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>