Petr Horáček has uploaded a new change for review.
Change subject: net: edit nic detached from bridge but still attached to a vlan ......................................................................
net: edit nic detached from bridge but still attached to a vlan
Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e Signed-off-by: Petr Horáček phoracek@redhat.com Bug-Url: https://bugzilla.redhat.com/1381880 --- M vdsm/network/configurators/ifcfg.py 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/65233/1
diff --git a/vdsm/network/configurators/ifcfg.py b/vdsm/network/configurators/ifcfg.py index bf93697..bc1c4c2 100644 --- a/vdsm/network/configurators/ifcfg.py +++ b/vdsm/network/configurators/ifcfg.py @@ -250,6 +250,11 @@ if set_mtu is not None: ipwrapper.linkSet(nic.name, ['mtu', str(set_mtu)])
+ # If the nic was bridged, we must remove BRIDGE parameter from its + # ifcfg configuration file. + if nic.bridge: + self.configApplier.dropBridgeParameter(nic.name) + def _getFilePath(self, fileType, device): return os.path.join(netinfo.NET_CONF_DIR, '%s-%s' % (fileType, device))
gerrit-hooks has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan ......................................................................
Patch Set 1: Verified-1
* #1381880::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1381880::OK, public bug * Check Product::#1381880::IGNORE, not relevant for classification: Red Hat * Check TM::#1381880::OK, correct target milestone ovirt-3.6.11 * Check merged to previous::WARN, Still open on branches ovirt-4.0, master
Petr Horáček has abandoned this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan ......................................................................
Abandoned
gerrit-hooks has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan ......................................................................
Patch Set 1:
* Update Tracker::#1381880::IGNORE, not relevant for Red Hat classification
Petr Horáček has restored this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan ......................................................................
Restored
Edward Haas has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan ......................................................................
Patch Set 1: Code-Review+1
Dan Kenigsberg has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan ......................................................................
Patch Set 1: Code-Review+2 Verified+1
copying score from 4.0.5
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: edit nic detached from bridge but still attached to a vlan ......................................................................
net: edit nic detached from bridge but still attached to a vlan
Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e Signed-off-by: Petr Horáček phoracek@redhat.com Bug-Url: https://bugzilla.redhat.com/1381880 Reviewed-on: https://gerrit.ovirt.org/65233 Continuous-Integration: Jenkins CI Reviewed-by: Edward Haas edwardh@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com Tested-by: Dan Kenigsberg danken@redhat.com --- M vdsm/network/configurators/ifcfg.py 1 file changed, 5 insertions(+), 0 deletions(-)
Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Verified; Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve
gerrit-hooks has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan ......................................................................
Patch Set 2:
* update_tracker: OK * Set MODIFIED::bug 1381880::::#1381880::::OK
vdsm-patches@lists.fedorahosted.org