Change in vdsm[master]: Initial unit tests implementation

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: Initial unit tests implementation
......................................................................

Initial unit tests implementation

Change-Id: I8009463ba2df27e800804cb42a14d8d530ad7e4f
---
M Makefile.am
M configure.ac
A tests/Makefile.am
A tests/main.py
M vdsm/storage/storage_exception.py
5 files changed, 49 insertions(+), 20 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/2356/1
--
To view, visit http://gerrit.ovirt.org/2356
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8009463ba2df27e800804cb42a14d8d530ad7e4f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Initial unit tests implementation
......................................................................

Patch Set 1: I would prefer that you didn't submit this

make rpm fails:

<snip>

make  check-local
make[3]: Entering directory `/home/vdsmdevel/rpmbuild/BUILD/vdsm-4.9.4/tests'
PYTHONPATH=../vdsm /usr/bin/python main.py
/usr/bin/python: can't open file 'main.py': [Errno 2] No such file or directory
make[3]: *** [check-local] Error 2
make[3]: Leaving directory `/home/vdsmdevel/rpmbuild/BUILD/vdsm-4.9.4/tests'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/home/vdsmdevel/rpmbuild/BUILD/vdsm-4.9.4/tests'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/home/vdsmdevel/rpmbuild/BUILD/vdsm-4.9.4'
error: Bad exit status from /var/tmp/rpm-tmp.Zw5Mo7 (%check)

RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.Zw5Mo7 (%check)
make: *** [rpm] Error 1

--
To view, visit http://gerrit.ovirt.org/2356
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8009463ba2df27e800804cb42a14d8d530ad7e4f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Initial unit tests implementation
......................................................................

Patch Set 3: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/2356
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8009463ba2df27e800804cb42a14d8d530ad7e4f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Federico Simoncelli

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Initial unit tests implementation
......................................................................

Patch Set 3: I would prefer that you didn't submit this

failed with 'make distcheck'

make[3]: Entering directory `/home/vdsmdevel/Feb28-vdsm/vdsm/vdsm-4.9.4/_build/tests'
PYTHONPATH=../vdsm /usr/bin/python main.py
/usr/bin/python: can't open file 'main.py': [Errno 2] No such file or directory
make[3]: *** [check-local] Error 2
make[3]: Leaving directory `/home/vdsmdevel/Feb28-vdsm/vdsm/vdsm-4.9.4/_build/tests'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/home/vdsmdevel/Feb28-vdsm/vdsm/vdsm-4.9.4/_build/tests'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/home/vdsmdevel/Feb28-vdsm/vdsm/vdsm-4.9.4/_build'
make: *** [distcheck] Error 1

--
To view, visit http://gerrit.ovirt.org/2356
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8009463ba2df27e800804cb42a14d8d530ad7e4f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Federico Simoncelli

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Initial unit tests implementation
......................................................................

Patch Set 4: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/2356
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8009463ba2df27e800804cb42a14d8d530ad7e4f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Federico Simoncelli

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Initial unit tests implementation
......................................................................

Patch Set 4: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/2356
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8009463ba2df27e800804cb42a14d8d530ad7e4f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Federico Simoncelli

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Initial unit tests implementation
......................................................................

Initial unit tests implementation

Change-Id: I8009463ba2df27e800804cb42a14d8d530ad7e4f
---
M Makefile.am
M configure.ac
A tests/Makefile.am
A tests/main.py
M vdsm/storage/storage_exception.py
5 files changed, 71 insertions(+), 20 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/2356
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8009463ba2df27e800804cb42a14d8d530ad7e4f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Federico Simoncelli