From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ngn: grab OS version according with /etc/os-release
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/73297/3/vdsm/caps.py
File vdsm/caps.py:
Line 566: else:
Line 567: return OSName.UNKNOWN
Line 568:
Line 569:
Line 570: def _parse_release_file(path):
just an idea: this function was introduced in
https://gerrit.ovirt.org/#/q/Ida119527b263302bf3f78e359bac12113718b744
how about backporting that patch first? That way, we'd also gain pretty_name in
3.6-ngn
Line 571: data = {}
Line 572: try:
Line 573: with open(path) as f:
Line 574: for line in f:
--
To view, visit
https://gerrit.ovirt.org/73297
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f35d8f2221c07a38e9d75b96324315266b0d51a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes