Change in vdsm[ovirt-3.4]: networkTests: BOND_NAME constant changed to bond11

Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

http://gerrit.ovirt.org/33529

to review the following change.

Change subject: networkTests: BOND_NAME constant changed to bond11
......................................................................

networkTests: BOND_NAME constant changed to bond11

getVdsCaps on rhel6 reports bond0-4 as existing
regardless of their true existence (see
_report_legacy_bondings).

This confuses the testing changes in upcoming
patches, hence we prefer to test a bond name with
no legacy burdens.

Change-Id: Id9f1892eaeae68583a792cb122cad4a5162e68fa
Signed-off-by: Petr Horáček 
Reviewed-on: http://gerrit.ovirt.org/31332
Reviewed-by: Dan Kenigsberg 
Tested-by: Dan Kenigsberg 
---
M tests/functional/networkTests.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/33529/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 141b47b..cbc6d0a 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -46,7 +46,7 @@

NETWORK_NAME = 'test-network'
 VLAN_ID = '27'
-BONDING_NAME = 'bond0'
+BONDING_NAME = 'bond11'
 IP_ADDRESS = '240.0.0.1'
 IP_NETWORK = '240.0.0.0'
 IP_ADDRESS_IN_NETWORK = '240.0.0.50'

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: networkTests: BOND_NAME constant changed to bond11
......................................................................

Patch Set 2: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/33529/2//COMMIT_MSG
Commit Message:

Line 12: 
Line 13: This confuses the testing changes in upcoming
Line 14: patches, hence we prefer to test a bond name with
Line 15: no legacy burdens.
Line 16: 
please explain why this is needed for a backport - do we really intend to backport these "upcoming patches"?

Also, please first backport to ovirt-3.5 branch.
Line 17: Change-Id: Id9f1892eaeae68583a792cb122cad4a5162e68fa
Line 18: Signed-off-by: Petr Horáček 
Line 19: Reviewed-on: http://gerrit.ovirt.org/31332
Line 20: Reviewed-by: Dan Kenigsberg

Petr Horáček has abandoned this change.

Change subject: networkTests: BOND_NAME constant changed to bond11
......................................................................

Abandoned